Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gcov code coverage #335

Merged
merged 7 commits into from
May 14, 2021
Merged

Add gcov code coverage #335

merged 7 commits into from
May 14, 2021

Conversation

salsal97
Copy link
Contributor

@salsal97 salsal97 commented May 3, 2021 •
edited
Loading

This PR adds code coverage support in the form of a new pipeline to the mystikos project. Sample coverage can be viewed here - https://openenclave.visualstudio.com/ACC-Services/_build/results?buildId=7269&view=results

@mikbras mikbras force-pushed the gcov branch 2 times, most recently from 7a21a7b to 78ffede Compare May 8, 2021 00:07
@salsal97 salsal97 force-pushed the gcov branch 3 times, most recently from c45c978 to e8ac624 Compare May 13, 2021 23:19
@salsal97 salsal97 changed the title WIP: Gcov Add gcov code coverage May 13, 2021
@salsal97 salsal97 force-pushed the gcov branch 5 times, most recently from 6427b2f to 7a937df Compare May 14, 2021 05:38
@salsal97 salsal97 requested a review from mikbras May 14, 2021 19:04
mikbras
mikbras reviewed May 14, 2021
View reviewed changes
Copy link
Contributor

@mikbras mikbras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this Saloni. It has come a long way since I saw it a week ago. Thank you for removing the legacy gcov too.

Makefile Outdated Show resolved Hide resolved
include/myst/gcov.h Outdated Show resolved Hide resolved
include/myst/gcov.h Outdated Show resolved Hide resolved
tests/Makefile Show resolved Hide resolved
tests/Makefile Outdated Show resolved Hide resolved
tests/clock/main.c Outdated Show resolved Hide resolved
tests/ltp/ext2fs_tests_passed.txt Outdated Show resolved Hide resolved
tools/myst/enc/gcov.c Outdated Show resolved Hide resolved
mikbras
mikbras reviewed May 14, 2021
View reviewed changes
gcov/gcovclient.c Outdated Show resolved Hide resolved
mikbras
mikbras reviewed May 14, 2021
View reviewed changes
gcov/gcovserver.c Outdated Show resolved Hide resolved
@salsal97
added script to summarize gcov
6be64cc 
remove mmap11 since it leaves stray threads

fix bug in ltp test makefile
@salsal97
remove solutions/tests that leave threads running
73c0c1d 
clean up code coverage pipeline

add nightly tests

update all references to the MYST_ENABLE_GCOV env

update documentation
@salsal97
increase timeout for sockperf
bb9ea26
@salsal97
remove sockperf since it leaves threads running
faca192
@salsal97
addressing pr comments
47ef374
@salsal97
change stderr ptr
9ec1f04
@salsal97
added distclean
686d818
@jxyang
Copy link
Contributor

jxyang commented May 14, 2021

Really impressive work. Thanks!

@salsal97 salsal97 merged commit 76f89a0 into deislabs:main May 14, 2021
@salsal97 salsal97 mentioned this pull request May 21, 2021
Closed
@bodzhang bodzhang mentioned this pull request Jun 2, 2021
Closed
@bodzhang bodzhang mentioned this pull request Jun 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikbras mikbras mikbras left review comments

@jxyang jxyang jxyang approved these changes

@paulcallen paulcallen paulcallen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salsal97 @jxyang @mikbras @paulcallen