-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add verifiers interface to wrap up operations on namespaced verifiers [multi-tenancy PR 2] #1358
feat: add verifiers interface to wrap up operations on namespaced verifiers [multi-tenancy PR 2] #1358
Conversation
f04f862
to
5bb783a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1358 +/- ##
==========================================
Coverage ? 65.31%
==========================================
Files ? 105
Lines ? 5458
Branches ? 0
==========================================
Hits ? 3565
Misses ? 1535
Partials ? 358 ☔ View full report in Codecov by Sentry. |
8096700
to
b60157e
Compare
b60157e
to
62973ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR Binbin! left some clarification questions.
Signed-off-by: Binbin Li <libinbin@microsoft.com>
00e4b21
to
b7e16ab
Compare
b7e16ab
to
810c93e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks Binbin!
Description
What this PR does / why we need it:
This is the second PR for multi-tenancy support. Please review this PR first.
VerifierManager
interface to wrap operations on the namespaced verifier resources.VerifierMap
variable undercontrollers
to a separate file so that both clustered and namespaced controllers could share it in the future.context
param to thegetExecutor
method so that Ratify could fetch the corresponding verifiers/stores/policies per namespace during initializing executor.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change