-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: build external plugins conditionally #860
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #860 +/- ##
=======================================
Coverage 54.96% 54.96%
=======================================
Files 80 80
Lines 4739 4739
=======================================
Hits 2605 2605
Misses 1850 1850
Partials 284 284 ☔ View full report in Codecov by Sentry. |
699938c
to
6845491
Compare
0bc5f2d
to
6714d5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR , in general looks good, left some minor comments.
4aac9c1
to
f265919
Compare
f265919
to
e767cbe
Compare
Description
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #858
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
e2e test passed.
Checklist:
Post Merge Requirements
Helm Chart Change