Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: build external plugins conditionally #860

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

binbin-li
Copy link
Collaborator

@binbin-li binbin-li commented May 31, 2023

Description

What this PR does / why we need it:

  1. Update Dockerfile so that it can select which external plugin to be built. The default building will just include notation verifier.
  2. Split test.bats to base_test and plugin_test. base_test will cover test cases running on image with built-in notation verifier. plugin_test will cover test cases for each added external plugin. Notes: the original test will be deleted in a following PR.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #858

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

e2e test passed.

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (72640d5) 54.96% compared to head (a6a5e65) 54.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #860   +/-   ##
=======================================
  Coverage   54.96%   54.96%           
=======================================
  Files          80       80           
  Lines        4739     4739           
=======================================
  Hits         2605     2605           
  Misses       1850     1850           
  Partials      284      284           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binbin-li binbin-li force-pushed the create-base-image branch 3 times, most recently from 699938c to 6845491 Compare May 31, 2023 10:19
@binbin-li binbin-li marked this pull request as draft May 31, 2023 10:58
@binbin-li binbin-li force-pushed the create-base-image branch 9 times, most recently from 0bc5f2d to 6714d5c Compare June 1, 2023 05:16
@binbin-li binbin-li marked this pull request as ready for review June 1, 2023 05:35
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR , in general looks good, left some minor comments.

Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@binbin-li binbin-li force-pushed the create-base-image branch 2 times, most recently from 4aac9c1 to f265919 Compare June 1, 2023 08:03
@binbin-li binbin-li merged commit ab7a2f9 into ratify-project:main Jun 6, 2023
@binbin-li binbin-li mentioned this pull request Jun 6, 2023
12 tasks
bspaans pushed a commit to bspaans/ratify that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ratify base image without external plugins
3 participants