This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
demo: kubectl version #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draychev
requested review from
michelleN,
asridharan,
vramakrishnan,
aanandr and
snehachhabria
Merged
asridharan
suggested changes
Jan 2, 2020
There was a problem hiding this comment.
- Minor NIT, can we capitalize the beginning of each of the sentence.
- An overview section would be really helpful. Users will have to build a lot of context to actually run the demo at this point, and most would be lost without explicitly talking to us. I believe the objective is to show traffic split? Would be good to state the goals and than get into the instructions.
|
@asridharan The goal of this PR was to move chunks from the existing repo. No doubt more documentation around the Demo would be helpful. |
michelleN
approved these changes
Jan 2, 2020
|
@draychev I'm happy to iterate on docs. Let's merge this and open an issue to track the suggestions @asridharan made ? |
aanandr
reviewed
Jan 2, 2020
bnookala
added a commit
to bnookala/osm
that referenced
this pull request
May 19, 2021
* Exposing validating webhook port in osm controller deployment. Signed-off-by: Bhargav Nookala <nooknb@gmail.com> * Adding config validator deployment and service Signed-off-by: Bhargav Nookala <nooknb@gmail.com> * Make port configurable Signed-off-by: Bhargav Nookala <nooknb@gmail.com>
bnookala
pushed a commit
to bnookala/osm
that referenced
this pull request
May 19, 2021
Cleanup of egress test OSM Webhook Deployment Templates (openservicemesh#12) * Exposing validating webhook port in osm controller deployment. Signed-off-by: Bhargav Nookala <nooknb@gmail.com> * Adding config validator deployment and service Signed-off-by: Bhargav Nookala <nooknb@gmail.com> * Make port configurable Signed-off-by: Bhargav Nookala <nooknb@gmail.com> more cleanup of egress test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an required
kubectlversion to the DEMO.md document per #11 (comment)