Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PasswordReset Completion issue #37

Closed
wassimz opened this issue Feb 8, 2016 · 3 comments
Closed

PasswordReset Completion issue #37

wassimz opened this issue Feb 8, 2016 · 3 comments

Comments

@wassimz
Copy link

wassimz commented Feb 8, 2016

Hi,

I am using this library with the Sequelize ORM and Mysql as database engine. My field "password_reset_time" is of type Timestamp and when the completion is done successfully and you try to put 0 in this field, an exception is raised. I will try to do more debugging the error but it seems not accepting the default time value.

By the way, I think allowing user to use or define these default values (X or 0) will be good while initializing the activator instance

Thanks

@deitch
Copy link
Owner

deitch commented Feb 8, 2016

You are talking about during the completePasswordReset()? I don't mind overriding the default, although since it all is included inside the activator library, it shouldn't matter. But why not. Put in a pull request to close this issue? Make sure to include validation tests, please.

@derekxm
Copy link

derekxm commented May 24, 2018

in your resetPassword function, you should provide two argument to their callback, e.g. callback(null, null). Their example has a bug.

@deitch
Copy link
Owner

deitch commented May 25, 2018

Issue opened #58

@deitch deitch closed this as completed May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants