Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Rate Limit exceeded errors #96

Closed
dgtized opened this issue Jan 4, 2024 · 6 comments · Fixed by #97 or #105
Closed

API Rate Limit exceeded errors #96

dgtized opened this issue Jan 4, 2024 · 6 comments · Fixed by #97 or #105

Comments

@dgtized
Copy link

dgtized commented Jan 4, 2024

On several projects using setup-clojure I've been encountering occasional failures from API rate limits.

As example:

Run DeLaGuardo/setup-clojure@12.1
  with:
    cli: latest
    bb: latest
    github-token: ***
    invalidate-cache: false
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.9-9/x64
    JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.9-9/x64

API rate limit exceeded for $IPADDRESS. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

Unfortunately, it's not clear from the error what documentation needs to be checked in order to authenticate for a higher rate limit.

It looks like this was previously encountered in #40 but was then removed in #45. From the error message I can't be sure, but I wonder if the fetch step for CLI is passing the token correctly but the corresponding logic for fetching babashka is not using a token?

I'm also using caching, but I'm curious if using latest instead of a specific version might be forcing cache misses.

Thank you very much for this very useful github action, hopefully we can find a solution to address the sporadic failures.

@DeLaGuardo
Copy link
Owner

Thanks for using it! And thanks for reporting this issue. I'll check tomorrow. Most likely some of the API calls don't use the provided github-token. Should be easy to fix.

One question - did you provide the token yourself? GitHub is printing action arguments with default values

@dgtized
Copy link
Author

dgtized commented Jan 4, 2024

I did not try providing a token, as it wasn't in the documentation. When I dug through and found #40 I considered it but wasn't sure if #45 actually removed the need for that?

@DeLaGuardo
Copy link
Owner

It should be fixed now. Please update to 12.2. Hopefully, you will not see rate limit error ever again :)

@dgtized
Copy link
Author

dgtized commented Jan 5, 2024

Thank you!

@imrekoszo
Copy link

Hey there, thanks a lot for your work!
Just wanted to give you a heads-up that I just saw an occurrence of this with version 12.3 at https://github.com/imrekoszo/polylith-kaocha/actions/runs/7709816905/job/21011785765

@lread
Copy link

lread commented Feb 9, 2024

Hi @DeLaGuardo! I hit a rate limit today, could be legit or maybe...

Did the setup for cli maybe not get updated to use githubAuth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants