Migrate the core of bespin to boto3 #22
Conversation
MVP approach to migrating cloudformation calls to boto3. More work should be done to migrate to boto3 resources and helpers (waiters, pagers). Adds support for update of stack tags
|
cool, thnx, I'll have a proper look a bit later on :) |
|
@delfick could you sign off on this. There's a number of other PRs hanging off it. |
|
ah yes, I'll look now |
bespin/amazon/cloudformation.py
Outdated
| self.session = session | ||
| if self.session is None: | ||
| self.session = boto3.session.Session(region_name=self.region) | ||
| assert self.session.region_name == self.region |
There was a problem hiding this comment.
I'm not a fan of asserts in code.
I'd rather we make session a memoized property than allow it to be passed in
@hp.memoized_property
def session(self):
return boto3.session.Session(region_name=self.region)
There was a problem hiding this comment.
Problem with your example is that is makes a new session for each (CF, EC2, S3...), rather than share the same session.
There was a problem hiding this comment.
It's not a major objection. Pushed new changes.
There was a problem hiding this comment.
aaahhh, it is too. I see the difference... hmmmm
Perhaps an object that holds onto a session per region, and we pass that into the intializer, which gets used to generate/reuse a session for that region.....
bespin/amazon/credentials.py
Outdated
| @@ -48,6 +45,8 @@ def verify_creds(self): | |||
| except botocore.exceptions.ClientError as error: | |||
| raise BespinError("Couldn't determine what account your credentials are from", error=error.message) | |||
|
|
|||
| assert self.session is not None and self.session.region_name == self.region | |||
There was a problem hiding this comment.
this should raise BespinError instead of an AssertionError
There was a problem hiding this comment.
This is more I did something wrong, so changed to ProgrammerError
|
lgtm |
Fixes: cab9f14 Fixes: delfick#22 Relates: delfick#17
Tag modifications are supported since migrating to boto3 in delfick#22
Migrate
bespin.amazon.credentialsandbespin.amazon.cloudformationto use boto3 (#17). This migrates what I consider the core of bespin (environments & stacks).Untouched modules (
bespin.amazon.ec2,s3,sqs,kms) will continue to operate using the boto authenticator off either the user's environment, or the overlaidassume_roleenvironment.The migration of the remaining modules will be done in separate PRs and will be tracked in #17.