Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softLimit and gracePeriod checks added #232

Merged
merged 5 commits into from
Aug 8, 2023
Merged

softLimit and gracePeriod checks added #232

merged 5 commits into from
Aug 8, 2023

Conversation

khareRajshree
Copy link
Contributor

Description

This PR includes changes for checks added to handle invalid softLimit and gracePeriod values.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#763

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit test (refer GitHub actions workflow)

VamsiSiddu-7
VamsiSiddu-7 previously approved these changes Aug 8, 2023
@khareRajshree khareRajshree merged commit 14fb414 into main Aug 8, 2023
4 of 5 checks passed
@khareRajshree khareRajshree deleted the nfs-fix-2 branch August 18, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants