Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to find gcc.h #50

Closed
hughsie opened this issue May 21, 2018 · 9 comments
Closed

Fails to find gcc.h #50

hughsie opened this issue May 21, 2018 · 9 comments

Comments

@hughsie
Copy link

hughsie commented May 21, 2018

Compiling inside flatpak I get:

In file included from /app/include/smbios_c/compat.h:27:0,
                 from /app/include/smbios_c/smi.h:22:
/app/include/smbios_c/config/get_config.h:36:39: fatal error: smbios_c/config/compiler/gcc.h: No such file or directory
 #  include LIBSMBIOS_C_COMPILER_CONFIG

Looking at the builddir I see:

$ ls build-dir/files/include/smbios_c/config/
abi_prefix.h  auto_link.h  get_config.h  msvc_prefix.h  select_compiler_config.h  suffix.h     user.h     win32.h
abi_suffix.h  gcc.h        linux.h       msvc_suffix.h  select_platform_config.h  sunpro_cc.h  visualc.h  win64.h

But select_compiler_config.h is looking for smbios_c/config/compiler/gcc.h -- i.e. with a compiler/ prefix that doesn't exist in reality. Either the gcc.h header is installed in the wrong directory (and sunpro_cc.h and visual_c.h) or the include is wrong.

@hughsie
Copy link
Author

hughsie commented May 22, 2018

I also think the files really need to go. Who cares about sunpro now? I also can't see msvc being a realistic option.

@superm1
Copy link
Contributor

superm1 commented May 22, 2018

Alright I'm going to open a separate bug to track removing all this boost stuff because it's going to require some surgery for all the #defines produced by it. For now we'll fix your issue with that PR (which I just re-pushed, so please test again).

@hughsie
Copy link
Author

hughsie commented May 23, 2018

Not quite:

/app/include/smbios_c/config/get_config.h:46:39: fatal error: smbios_c/config/platform/linux.h: No such file or directory

@superm1
Copy link
Contributor

superm1 commented May 29, 2018

OK, I see, some subdirectory headers too. Just got a chance to try again. Can you please retry with the updated PR?

@hughsie
Copy link
Author

hughsie commented May 29, 2018

Can you rebase wip/superm1/fix-include against master please? It makes my life easier to build a flatpak.

@superm1
Copy link
Contributor

superm1 commented May 29, 2018

Sure thing, just did.

@hughsie
Copy link
Author

hughsie commented May 29, 2018

Thanks, sorry to be the harbinger of doom:

/app/include/smbios_c/config/get_config.h:46:39: fatal error: smbios_c/config/platform/linux.h: No such file or directory

This exists build-dir/files/include/smbios_c/platform/linux.h but not in /config...

@superm1
Copy link
Contributor

superm1 commented May 29, 2018

< sigh > Alright I made one more change, can you try again?

@hughsie
Copy link
Author

hughsie commented May 29, 2018

Works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants