Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle failure codes as failures #20

Closed
wrouesnel opened this issue Sep 28, 2017 · 5 comments
Closed

Handle failure codes as failures #20

wrouesnel opened this issue Sep 28, 2017 · 5 comments
Labels

Comments

@wrouesnel
Copy link
Contributor

It looks like a lot of failure codes aren't picked up as module failures, and thus treat the host as "ok" despite nothing working - i.e. this 401 error shows as green:
ok: [fresh.nodes -> provisioning] => {"changed": false, "failed": false, "result": 401}

@jose-delarosa
Copy link
Contributor

What playbook were you running? I agree error detection can be improved. Pull requests are welcome :)

@wrouesnel
Copy link
Contributor Author

I should have something later :)

@jose-delarosa
Copy link
Contributor

Working on catching failures, should have it committed by end of day 10.02

@jose-delarosa
Copy link
Contributor

Try again with latest commit. All existing functions now handle most error codes correctly.

@jose-delarosa
Copy link
Contributor

If problem persists, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants