Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emoji list to emoji v15.0. #58

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lushangkan
Copy link

Context

Update emoji list to emoji version.
Add option to customize emoji list.

Summary

Update emoji list to emoji v15.0.
Change emoji grouping to official grouping.
Add option to customize emoji list.
Change default group icon to lucide icon.
Modify Header Padding to accommodate new grouping size.
Modify Header flex option to fix off-center icons.
Updating npm dependencies.
Fix some bugs.
And more...

To-do

  • Due to the change in emoji grouping, users may need to be reminded of the change in the documentation in the future.

User-facing changes

Too much changes. Comment it if you need.

Checklist

  • I have tested this code to the best of my abilities
  • I have added documentation where necessary

Change emoji grouping to official grouping.

Add option to customize emoji list.

Change default group icon to lucide icon.

Modify Header Padding to accommodate new grouping size.

Modify Header flex option to fix off-center icons.

Updating npm dependencies.

Fix some bugs.

And more...
@codesandbox
Copy link

codesandbox bot commented Aug 16, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@delowardev
Copy link
Owner

Hi @lushangkan Thank you for the PR; I will review the changes and merge it as soon as possible.

@delowardev delowardev self-requested a review August 17, 2023 03:55
@lushangkan
Copy link
Author

Seems like I didn't handle skin tones well, I'll fix that later

@lushangkan
Copy link
Author

Fixed unsupported skin color issue, zwj_emoji not supported for now (except Other group)

Copy link
Owner

@delowardev delowardev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lushangkan, thanks again for your incredible effort on this.

PR looks good, just two minor changes needed:

  1. You may want to update the emoji cdn URL as well in constant.ts#L3, the new src should be https://cdn.jsdelivr.net/npm/emoji-datasource-apple@15.0.1/img/apple/64/

export const EMOJI_REMOTE_SRC =
'https://cdn.jsdelivr.net/npm/emoji-datasource-apple@6.0.1/img/apple/64'

  1. In emojis.json#10461, could you please update 2642-fe0f to 2641-fe0f? I noticed the male sign emoji doesn't show with the previous code for some reason.

"u": "2642-fe0f"

@lushangkan
Copy link
Author

Hi @lushangkan, thanks again for your incredible effort on this.

PR looks good, just two minor changes needed:

  1. You may want to update the emoji cdn URL as well in constant.ts#L3, the new src should be https://cdn.jsdelivr.net/npm/emoji-datasource-apple@15.0.1/img/apple/64/

export const EMOJI_REMOTE_SRC =
'https://cdn.jsdelivr.net/npm/emoji-datasource-apple@6.0.1/img/apple/64'

  1. In emojis.json#10461, could you please update 2642-fe0f to 2641-fe0f? I noticed the male sign emoji doesn't show with the previous code for some reason.

"u": "2642-fe0f"

Thank you for checking it out!
I've noticed some new issues in the meantime, I'll get back to you when I'm done fixing them.
Also, emoji added a lot of zwj emoji to switch the gender of the character within the emoji, etc., do you have plans to adapt it?

@delowardev
Copy link
Owner

I think zwj emoji will be a good feature, I will need to check the possibilities.

Modify test module to accommodate new emojis.json.
Modify the emoji resource version.
@lushangkan
Copy link
Author

  1. 2641-fe0f

Is the 2641 the ♁ symbol you are referring to? The symbol is earth symboldeprecated in Unicode 1.1, I switched 2642 to 2641 in my device (Windows 11) and it shows up as image, and I didn't find this icon in the official list of Unicode either

1 2

Hi @lushangkan, thanks again for your incredible effort on this.

PR looks good, just two minor changes needed:

  1. You may want to update the emoji cdn URL as well in constant.ts#L3, the new src should be https://cdn.jsdelivr.net/npm/emoji-datasource-apple@15.0.1/img/apple/64/

export const EMOJI_REMOTE_SRC =
'https://cdn.jsdelivr.net/npm/emoji-datasource-apple@6.0.1/img/apple/64'

  1. In emojis.json#10461, could you please update 2642-fe0f to 2641-fe0f? I noticed the male sign emoji doesn't show with the previous code for some reason.

"u": "2642-fe0f"

Is the 2641 the ♁ symbol you are referring to? The symbol is earth symbol, deprecated in Unicode 1.1, I switched 2642 to 2641 in my device (Windows 11) and it shows up as image, and I didn't find this icon in the official list of Unicode either

@lushangkan
Copy link
Author

Hi @lushangkan, thanks again for your incredible effort on this.

PR looks good, just two minor changes needed:

  1. You may want to update the emoji cdn URL as well in constant.ts#L3, the new src should be https://cdn.jsdelivr.net/npm/emoji-datasource-apple@15.0.1/img/apple/64/

export const EMOJI_REMOTE_SRC =
'https://cdn.jsdelivr.net/npm/emoji-datasource-apple@6.0.1/img/apple/64'

  1. In emojis.json#10461, could you please update 2642-fe0f to 2641-fe0f? I noticed the male sign emoji doesn't show with the previous code for some reason.

"u": "2642-fe0f"

I see the request https://fastly.jsdelivr.net/npm/emoji-datasource-apple@15.0.1/img/apple/64/2642-fe0f.png failed message in the console, which could be a problem with the emoji-datasource-apple repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants