Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Type Definitions #61

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Export Type Definitions #61

merged 3 commits into from
Oct 11, 2023

Conversation

AAllport
Copy link
Contributor

Context

Many users using Typescript will want events to have type definitions.
As such, we can export them here, to avoid :any types and increase DX

Summary

Added exports for types

Relevant Technical Choices

To-do

User-facing changes

Checklist

  • I have tested this code to the best of my abilities
  • I have added documentation where necessary

Fixes #49

@codesandbox
Copy link

codesandbox bot commented Oct 11, 2023

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@delowardev
Copy link
Owner

Thanks so much for adding the type definitions.

@delowardev delowardev merged commit 5628aaf into delowardev:main Oct 11, 2023
2 checks passed
@AAllport
Copy link
Contributor Author

I'd be lying if I said anything other than how I was scratching my own itch :p
Thanks for being responsive and merging it quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delowardev delowardev delowardev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use componente vue+ typescript
2 participants
@AAllport @delowardev