Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ruff #384

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Switch to ruff #384

merged 7 commits into from
Dec 12, 2023

Conversation

goodmami
Copy link
Member

Closes #383

@goodmami
Use Ruff for linting
6ec7855
@goodmami
Linting fix: import blocks and getattr/setattr
44a1e94 
Sorts imports and normalizes whitespace in the upper part of modules.
Also fixes unnecessary use of getattr/setattr
@goodmami
Linting fix: unused loop variables
02cb3db
@goodmami
Linting fix: explicit stacklevel on warnings
0d60194
@goodmami
Disable complexity and naming checks for now
e2e7c5f
@goodmami
Linting fix: raise from
6a543f5
@goodmami
Set MyPy's python version, disable a check
d56a5b0 
The 'method-assign' check was interfering with the previous removal of
the "unnecessary" setattrs in ace.py.
@goodmami
Copy link
Member Author

Besides switching the tooling to Ruff, this PR resolves several linting issues that it uncovered. I did not do the ruff format steps, so there are more changes to be made eventually.

@goodmami goodmami merged commit 0fd7a6c into main Dec 12, 2023
14 checks passed
@goodmami goodmami deleted the switch-to-ruff branch December 12, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to Ruff for linting
1 participant
@goodmami