Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build on rust 1.46 #58

Closed
rtyler opened this issue Jan 9, 2021 · 1 comment
Closed

Cannot build on rust 1.46 #58

rtyler opened this issue Jan 9, 2021 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@rtyler
Copy link
Member

rtyler commented Jan 9, 2021

This is an error I saw on a Linux/amd64 machine while building the rust bindings. My guess is we just need to document the right version of the compiler and toolchain we should be relying upon

➜  rust git:(40443d6) rustc --version
rustc 1.46.0 (04488afe3 2020-08-24)
➜  rust git:(40443d6) cargo test --features azure               
   Compiling deltalake v0.2.0 (/home/tyler/source/github/delta-io/delta.rs/rust)
error: no rules expected the token `,`
  --> rust/tests/read_error_test.rs:12:46
   |
12 |         deltalake::DeltaTableError::NotATable,
   |                                              ^ no rules expected this token in macro call

error: aborting due to previous error

error: could not compile `deltalake`.

To learn more, run the command again with --verbose.
@rtyler rtyler added the bug Something isn't working label Jan 9, 2021
@rtyler rtyler added documentation Improvements or additions to documentation good first issue Good for newcomers labels Mar 2, 2021
@rtyler
Copy link
Member Author

rtyler commented Apr 28, 2021

That compiler is old enough to where I don't know if there's anything worth documenting.

@rtyler rtyler closed this as completed Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant