Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing bracket in URLs not recognised #2238

Closed
msCran19 opened this issue May 7, 2021 · 2 comments · Fixed by #2291
Closed

Closing bracket in URLs not recognised #2238

msCran19 opened this issue May 7, 2021 · 2 comments · Fixed by #2291
Labels
bug Something isn't working

Comments

@msCran19
Copy link

msCran19 commented May 7, 2021

  • Operating System (Linux/Mac/Windows/iOS/Android):

Windows 7, Windows 10

  • Delta Chat Version:

1.15.5

  • Expected behavior:

A URL like https://en.wikipedia.org/wiki/Bracket_(disambiguation) sent in a DeltaChat message should open on click without problems.

  • Actual behavior:

The closing bracket is omitted, i.e. the link opened in the browser is https://en.wikipedia.org/wiki/Bracket_(disambiguation

  • Steps to reproduce the problem:

Send the URL https://en.wikipedia.org/wiki/Bracket_(disambiguation) as message in DeltaChat and then click it.

Furthermore, different bevaviour for different (combinations of) closing brackets can be observed. Send the following links as DeltaChat message and then click the links:
https://delta.chat
https://delta.chat)
https://delta.chat}
https://delta.chat]}
Especially the last one is slightly worrying (as it opens the Windows Explorer).

The problem doesn't occur on Android.

@Simon-Laux Simon-Laux added the bug Something isn't working label May 8, 2021
@Jikstra
Copy link
Contributor

Jikstra commented May 18, 2021

@Simon-Laux we are fixing your regex again and again, maybe time to use something like https://www.npmjs.com/package/linkifyjs ?

@Simon-Laux
Copy link
Member

Simon-Laux commented May 19, 2021

I rather think its time for message parsing in the core, but that's nothing we can quickly do now. Also I think including linkify is not trivial either, even if its probably still easier than a core feature, fixing the regex is probably faster.
also we could create unit tests for the regexps.

possible loosely related https://support.delta.chat/t/problem-with-shared-links-that-contain-other-languages/1645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants