Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications are sometimes not removed from notification center [needs step to reproduce] #3937

Open
r10s opened this issue Jun 12, 2024 · 11 comments
Labels
bug Something isn't working

Comments

@r10s
Copy link
Member

r10s commented Jun 12, 2024

notifications show up in the notification center of mac, however, they are not removed when the corresponding chat is opened and the belonging messages are no longer "fresh".

eg. on android/ios, we dismiss all notifications belonging to a chat once the chat is opened, i assume sth. like that would be nice for desktop as well.

eg. the following image shows some profiles where none of them have a new message - but the notification center (rights) shows lots of messages, some of them days old:

Screenshot 2024-06-13 at 00 19 55

there was a similar issue at #2199, tbh, not sure when it stopped working again

@r10s r10s added the bug Something isn't working label Jun 12, 2024
@Simon-Laux
Copy link
Member

eg. on android/ios, we dismiss all notifications belonging to a chat once the chat is opened, i assume sth. like that would be nice for desktop as well.

this is what it does for me, just tested it again.

I can not reproduce this, could those notifications be remaining from a previous session (like be from that bug: #2438, I'm not sure if we can solve that bug maybe we should just remove all notifications if you close deltachat?)

@nicodh
Copy link
Contributor

nicodh commented Jun 17, 2024

Can't reproduce this in Catalina too. Works as expected...

@r10s
Copy link
Member Author

r10s commented Jun 17, 2024

i had similar many messages as in the image above just now.

clearing all these messages (i think, i tried that before, but well, not 100% sure), i can confirm, on explicit tries notificaitions are removed as expected.

also, quitting the app seem to remove all notification.

so, let's close this issue, maybe it was the case that in older versions notifications were not removed on exit and then got orphaned.

if i again see lots of stale notifications, i know that i removed them all by re-reading this message :)

@r10s r10s closed this as completed Jun 17, 2024
@r10s
Copy link
Member Author

r10s commented Jun 20, 2024

ftr, having stale notifications again, however, i cannot say how to reproduce the issue yet.

i suspect it is somehow related to multiple devices

@r10s
Copy link
Member Author

r10s commented Jun 25, 2024

i have the issue again, btw.

i suspect, it is related to multi-device somehow, but i did not find a way to reproduce it somehow. it is just that after some time not watching, the notification center is flooded as shown in the image above.

@Simon-Laux
Copy link
Member

So you haven't restarted it in between?

@Simon-Laux Simon-Laux reopened this Jun 25, 2024
@Simon-Laux Simon-Laux changed the title notifications are not removed from notification center notifications are sometimes not removed from notification center [needs step to reproduce] Jun 25, 2024
@r10s
Copy link
Member Author

r10s commented Jun 25, 2024

So you haven't restarted it in between?

exiting the app does remove all notifications for me, that works.

so, yes, i probably have not restarted for some time.

in general, the app is running for hours, sometimes days, including suspend times where i use a second device. i suspect that is where things somehow go wrong. but as said, i cannot really say more than that it happens :)

@Simon-Laux
Copy link
Member

Have you started and stopped from command line or killed the app otherwise? then it might not have a chance to clear old notifications?

@r10s
Copy link
Member Author

r10s commented Jul 1, 2024

no, not that i was aware of

@WofWca
Copy link
Collaborator

WofWca commented Jul 3, 2024

See if reproduction steps in #3982 work for you

@Simon-Laux
Copy link
Member

Simon-Laux commented Jul 31, 2024

Bildschirmfoto 2024-08-01 um 00 05 55

I believe there is no logic to clear those generic / summarised notifications. Those piled up for me in my notification center.
we should clear all of those summary messages when delta chat is focused. but this might deserve a dedicated issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants