Do not show redundant read-only message when in device messages chat #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adzialocha
changed the title
adzialocha
changed the title
r10s
reviewed
Nov 16, 2023
There was a problem hiding this comment.
great! lgtm, and i also tested a bit, everything as expected
leaving final approval to @Simon-Laux as i do not know much about how code is organised and should look like on desktop
(ftr, i know some things about android/ios, fewer things about core and very few things about desktop code - i only try to keep an eye on ux/ui there and can do only very basic PRs)
Simon-Laux
reviewed
Nov 16, 2023
Simon-Laux
approved these changes
Nov 16, 2023
Simon-Laux
reviewed
Nov 16, 2023
adzialocha
added a commit
that referenced
this pull request
Nov 21, 2023
* master: (29 commits) fix double message context menu (#3551) fix displaying sticker that has wrong mimetype (#3552) fix bug where composer was locked after joining a group via qr code (#3547) prepare 1.41.3 comment out verbose logging of store add `vi` to appx supported languages let's hope that this does not break the ms store again, it was on the ms list of supported languages, so I hope that it does not break it. Update translations (17.11.2023) and add Vietnamese language fix translation key for `add_to_sticker_collection` in context menu (#3544) fix eslint Select device message chat automatically to welcome first users (#3531) Improve layout and fix unknown locale of `DisabledMessageInput` (#3537) Use `dc_chat_can_send` to show or hide reply functionality (#3541) add more debug logging when clearing notifications (#3534) update deltachat-node and deltachat/jsonrpc-client to `v1.131.4` (#3539) update local help (#3538) Fix: Do not show reply option in read-only groups (#3536) Update options for disappearing messages (#3530) Do not show redundant read-only message when in device messages chat (#3532) fix: bug in emoji detection for jumbomoji #3508 update deltachat-node and deltachat/jsonrpc-client to `v1.131.3` ...
r10s
added a commit
that referenced
this pull request
Apr 8, 2024
to not clutter UI, we do not show a "reasoning bar" at all for the device chat; the case `DisabledChatReasons.DEVICE_CHAT` should not be executed at all. the string was already removed in #3532 but then came back somehow :)
r10s
added a commit
that referenced
this pull request
Apr 8, 2024
to not clutter UI, we do not show a "reasoning bar" at all for the device chat. the string was already removed in #3532 but then came back somehow :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides the composer view including it's little message when being in the read-only "Device Message" chat as it didn't add much information for the user.
Also, I've done a mini-refactoring, moving this logic into own component and hook files.
Closes #3511