Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make a test for build_wallet_positions.py #1408

Closed
dpaiton opened this issue Apr 11, 2024 · 1 comment
Closed

make a test for build_wallet_positions.py #1408

dpaiton opened this issue Apr 11, 2024 · 1 comment
Labels
enhancement A feature or refactor request good first issue New to the repo? Start here! testing Tasks that require creating or improving tests

Comments

@dpaiton
Copy link
Member

dpaiton commented Apr 11, 2024

#1407 revealed a bug in how we build up the wallet from on-chain trades. We should be able to build a test for this that verifies wallet construction from each of the possible wallet quantities.
@dpaiton dpaiton added enhancement A feature or refactor request good first issue New to the repo? Start here! testing Tasks that require creating or improving tests labels Apr 11, 2024
@dpaiton dpaiton mentioned this issue May 1, 2024
Closed
@slundqui
Copy link
Contributor

Comparison of this wallet correctness against the db and chain was audited and implemented in #1467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A feature or refactor request good first issue New to the repo? Start here! testing Tasks that require creating or improving tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpaiton @slundqui