Updated CommonServerPython with new fields for field restructure #18051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ni-Knight
changed the title
8 tasks
yaakovi
reviewed
Apr 3, 2022
# Conflicts: # Packs/Base/ReleaseNotes/1_18_18.md # Packs/Base/pack_metadata.json
Co-authored-by: Shai Yaakovi <30797606+yaakovi@users.noreply.github.com>
Co-authored-by: Shai Yaakovi <30797606+yaakovi@users.noreply.github.com>
Co-authored-by: Shai Yaakovi <30797606+yaakovi@users.noreply.github.com>
…es-Updates' into CommonServerPython-Indicator-Types-Updates
|
This pull request introduces 1 alert when merging fad7c30 into 2c6cacf - view on LGTM.com new alerts:
|
Switched the new class back to `certificates` as the class `certificate` already exists
There is always at least 1 hash, so list is never empty.
|
This pull request introduces 1 alert when merging 4d7fb88 into 4a6a939 - view on LGTM.com new alerts:
|
MislavReversingLabs
approved these changes
Apr 26, 2022
ShacharKidor
requested changes
Apr 28, 2022
There was a problem hiding this comment.
Hi @Ni-Knight,
Nice work!
I added unit tests and a few little corrections.
Please see the correction I added to the Account class that deals with the CommunityNotes field in the 'to_context' function.
In addition please see review comments.
Let me know if you have any questions :)
MislavReversingLabs
approved these changes
Apr 29, 2022
# Conflicts: # Packs/AccentureCTI/pack_metadata.json # Packs/Base/ReleaseNotes/1_30_2.md # Packs/Base/pack_metadata.json
…s to Account context
ShacharKidor
approved these changes
May 9, 2022
Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com>
JudahSchwartz
approved these changes
May 9, 2022
|
Link to the unit tests coverage report: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Added the needed attributes to indicator Classes under the
Commonclass.Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have