-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'aws-ec2-authorize-security-group-egress-rule' command #20018
add 'aws-ec2-authorize-security-group-egress-rule' command #20018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor!
A couple more minor comments here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesomesauce
@ShahafBenYakir We need forcemerge on this PR due to low coverage issues (generate-unit-tests didn't work in the case of this integration. |
* test * added rn * added readme * adding unit-tests * adding unit-tests * added unit tests * edit TPB * fixes * CR fixes * cr fixes * lint fixes
* Feat(Cortex XSOAR/content): Add SEKOIA.IO integration (#19928) * Feat(Cortex XSOAR/content): Add SEKOIA.IO integration * Feat(Cortex XSOAR/content/SEKOIA.IO): Apply review suggestions by @squioc. * Use demisto/stix2 docker image * Apply suggestions from code review by @MosheEichler Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Apply remaining review suggestions of @MosheEichler. * Fix tests. * Remove duplicate entries in `pack_metadata.json.lock`, delete `pack_metadata.json.lock` and fix typo. * Harmonize context output names, ignore secrets and remove empty description file. Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * hide deprecated non relevant packs (#20122) * Update Docker Image To demisto/crypto (#20131) * Updated Metadata Of Pack MicrosoftGraphIdentityandAccess * Added release notes to pack MicrosoftGraphIdentityandAccess * Packs/MicrosoftGraphIdentityandAccess/Integrations/MicrosoftGraphIdentityandAccess/MicrosoftGraphIdentityandAccess.yml Docker image update * Update Docker Image To demisto/google-api-py3 (#20132) * Updated Metadata Of Pack GCP-IAM * Added release notes to pack GCP-IAM * Packs/GCP-IAM/Integrations/GCPIAM/GCPIAM.yml Docker image update * Updated Metadata Of Pack GmailSingleUser * Added release notes to pack GmailSingleUser * Packs/GmailSingleUser/Integrations/GmailSingleUser/GmailSingleUser.yml Docker image update * Updated Metadata Of Pack GoogleCloudFunctions * Added release notes to pack GoogleCloudFunctions * Packs/GoogleCloudFunctions/Integrations/GoogleCloudFunctions/GoogleCloudFunctions.yml Docker image update * Update Docker Image To demisto/googleapi-python3 (#20133) * Updated Metadata Of Pack GoogleCalendar * Added release notes to pack GoogleCalendar * Packs/GoogleCalendar/Integrations/GoogleCalendar/GoogleCalendar.yml Docker image update * Updated Metadata Of Pack GoogleDrive * Added release notes to pack GoogleDrive * Packs/GoogleDrive/Integrations/GoogleDrive/GoogleDrive.yml Docker image update * Updated Metadata Of Pack GoogleSheets * Added release notes to pack GoogleSheets * Packs/GoogleSheets/Integrations/GoogleSheets/GoogleSheets.yml Docker image update * Updated Metadata Of Pack GsuiteAuditor * Added release notes to pack GsuiteAuditor * Packs/GsuiteAuditor/Integrations/GsuiteAuditor/GsuiteAuditor.yml Docker image update * Update Docker Image To demisto/fastapi (#20134) * Updated Metadata Of Pack GenericWebhook * Added release notes to pack GenericWebhook * Packs/GenericWebhook/Integrations/GenericWebhook/GenericWebhook.yml Docker image update * Aburt-MitreCaldera (#19482) (#20125) * Initial commit * Fixed some linting errors and format * Made major changes * Added more custom content * Updated linting errors * Updated several files * Fixed linting errors * Removed dummy file * Updated README * Updated description * Updated several commands * REverted lock file * Added fromversion * Fixed code based on comments * Updated code again * Fixed coding based on comments * Fixed linting errors * Added author image * Fixed linting errors * Repalced old author_image * Changed author image files * Fixed linting errors * Updated incident field names * Fixed script issues and linting issues * Fixed code issue * Fixed return errors in scripts * Fixed linting errors * Changed api_key to credentials * Changed api_key param to support credentials * Added description * Updated Playbook ID * Fixed linting errors * Fixed linting errors * correct autor_image & fix lint error * Fixed linting * Updated Docker Images * Delete pack_metadata.json.lock * Added new incident options and updated docker * fix linting Co-authored-by: ilappe <ilappe@paloaltonetworks.com> Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com> Co-authored-by: Adam Burt - Demisto <53576129+aburt-demisto@users.noreply.github.com> Co-authored-by: ilappe <ilappe@paloaltonetworks.com> Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com> * [greynoise-266] Add ability to set Integration Reliability Value (#20139) * [greynoise-266] Add ability to set Integration Reliability Value (#19676) * initial commit for reliability update * Update Packs/GreyNoise/Integrations/GreyNoise/GreyNoise.py Co-authored-by: israelpoli <72099621+israelpoli@users.noreply.github.com> * Update Packs/GreyNoise/Integrations/GreyNoise/GreyNoise.py Co-authored-by: israelpoli <72099621+israelpoli@users.noreply.github.com> * Update Packs/GreyNoise/Integrations/GreyNoise/GreyNoise.py Co-authored-by: israelpoli <72099621+israelpoli@users.noreply.github.com> * Update Packs/GreyNoise/Integrations/GreyNoise_Community/GreyNoise_Community.py Co-authored-by: israelpoli <72099621+israelpoli@users.noreply.github.com> * update quick command and release notes * fix test data url * update unittest for coverage * updates to RIOT command unit test * add main unittest for GC * fix bad import Co-authored-by: israelpoli <72099621+israelpoli@users.noreply.github.com> * Correction to the RN Co-authored-by: Brad Chiappetta <38439955+bradchiappetta@users.noreply.github.com> Co-authored-by: israelpoli <72099621+israelpoli@users.noreply.github.com> Co-authored-by: israelpolishook <ipolishuk@paloaltonetworks.com> * Update marketplace name (lowercase), update author from dev to compan… (#20099) (#20111) * Update marketplace name (lowercase), update author from dev to company name ("iboss"), update categories to Network Security. * Update version number in pack.metadata * JSON validation fix * Ignored error Co-authored-by: aradcarmi <aradcarmi220@gmail.com> Co-authored-by: Mike Forgione <mvforgione@gmail.com> Co-authored-by: aradcarmi <aradcarmi220@gmail.com> * Rasterize - pass html as UTF-8 (#20056) * ovveride the meta tag * fix linting * CR changes * fix lints * clean fix * update docker image * Update Packs/rasterize/ReleaseNotes/1_2_1.md Co-authored-by: Guy Lichtman <1395797+glicht@users.noreply.github.com> Co-authored-by: Guy Lichtman <1395797+glicht@users.noreply.github.com> * Pushing update to re-add missing integration (#20110) * TEst fix * Testing fix * new commit fix * locked * Updated SDK to beta-integration hot-fix * Downgrade pack version * pep 8 * Add resources to SumoCloud Siem Integration: (#20138) Co-authored-by: Kobbi Gal <85439776+kgal-pan@users.noreply.github.com> Co-authored-by: Luke Milby <96145227+lmilby-sumo@users.noreply.github.com> Co-authored-by: Duc Ha <duchatran@gmail.com> Co-authored-by: kgal-pan <kgal@paloaltonetworks.com> * add 'aws-ec2-authorize-security-group-egress-rule' command (#20018) * test * added rn * added readme * adding unit-tests * adding unit-tests * added unit tests * edit TPB * fixes * CR fixes * cr fixes * lint fixes * Dev-Task - removed excessive traceback error printing - Packs C (#19484) * removed excessive traceback error printing * Update docker image * Updated docker image * Revert carbon black * revert AddKeyToList * Revert common scripts * revert Cryptocurrency,CircleCI,Censys * add packs * pack metadata * changes after cr * docker image * docker image * docker image * docker image * docker * Azure sentinel bug fix (#20053) * fixed tactics field * added techniques to incident and RN * changed default source to microsoft * fixed list index issue * safe get dict * fixed source issue * comment to explain the source arg * fixed and added test * MITRE Corporation Co-authored-by: lilyus <8960084+PierrickV@users.noreply.github.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> Co-authored-by: Bar Katzir <37335599+bakatzir@users.noreply.github.com> Co-authored-by: Adam Burt - Demisto <53576129+aburt-demisto@users.noreply.github.com> Co-authored-by: ilappe <ilappe@paloaltonetworks.com> Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com> Co-authored-by: Brad Chiappetta <38439955+bradchiappetta@users.noreply.github.com> Co-authored-by: israelpoli <72099621+israelpoli@users.noreply.github.com> Co-authored-by: israelpolishook <ipolishuk@paloaltonetworks.com> Co-authored-by: Mike Forgione <mvforgione@gmail.com> Co-authored-by: aradcarmi <aradcarmi220@gmail.com> Co-authored-by: Guy Lichtman <1395797+glicht@users.noreply.github.com> Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> Co-authored-by: Kobbi Gal <85439776+kgal-pan@users.noreply.github.com> Co-authored-by: Luke Milby <96145227+lmilby-sumo@users.noreply.github.com> Co-authored-by: Duc Ha <duchatran@gmail.com> Co-authored-by: kgal-pan <kgal@paloaltonetworks.com> Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com> Co-authored-by: yucohen <86777474+yucohen@users.noreply.github.com> Co-authored-by: meichlerpanw <meichler@paloaltonetworks.com>
Status
Related Issues
fixes: CIAC-646
Description
Added 'aws-ec2-authorize-security-group-egress-rule' command to aws-ec2 integration.
Does it break backward compatibility?