Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query filters to requests #21076

Merged
merged 4 commits into from Sep 19, 2022
Merged

Add query filters to requests #21076

merged 4 commits into from Sep 19, 2022

Conversation

ghost
Copy link

@ghost ghost commented Sep 7, 2022

  • Add a new field to the configuration form for including/excluding resolved alerts in the response's payload
  • Add default query filters to the assets requests
  • Add default query filters to the alerts requests
  • Replace demisto's deprecated functions

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • [] In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

See the commit's message

Screenshots

image

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Sep 7, 2022
@content-bot content-bot changed the base branch from master to contrib/heziclaroty_claroty/add-query-filters-to-alerts-and-assets-requests September 7, 2022 14:06
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YuvHayun will know he can start review the proposed changes.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Sep 7, 2022
YuvHayun
YuvHayun requested changes Sep 11, 2022
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @heziclaroty, thank you for your contribution!
Please see my comments.

Packs/Claroty/Integrations/Claroty/Claroty.yml Outdated Show resolved Hide resolved
Packs/Claroty/ReleaseNotes/1_0_18.md Outdated Show resolved Hide resolved
@YuvHayun YuvHayun added the pending-contributor The PR is pending the response of its creator label Sep 11, 2022
@lgtm-com
Copy link

lgtm-com bot commented Sep 11, 2022

This pull request introduces 1 alert when merging 66a3772c7f415eb33d9b3f6cb3b626ed47448515 into 94da638 - view on LGTM.com

new alerts:

  • 1 for Syntax error

YuvHayun
YuvHayun requested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @heziclaroty, thx for your quick response.
See my new comments below please.

Packs/Claroty/Integrations/Claroty/Claroty_test.py Outdated Show resolved Hide resolved
Packs/Claroty/Integrations/Claroty/Claroty_test.py Outdated Show resolved Hide resolved
Packs/Claroty/ReleaseNotes/1_0_18.md Outdated Show resolved Hide resolved
@YuvHayun
Copy link
Contributor

Please fill the cla @heziclaroty

@YuvHayun YuvHayun added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Sep 12, 2022
@content-bot
Copy link
Collaborator

content-bot commented Sep 12, 2022 •
edited
Loading

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/3683763

@YuvHayun
Copy link
Contributor

Hey, @heziclaroty I see that all tests passed.
I'd like to schedule a quick demo call just to talk about the changes and see some commands running in real-time to make sure everything is still working correctly.
Please DM me on the slack DFIR channel "Yuval Hayun" so we can set an appointment.

@YuvHayun YuvHayun added the pending-demo Demo pending label Sep 12, 2022
Hezi added 2 commits September 13, 2022 23:19
Add query filters to requsets
06ebd04 
- Add a new field to configuration form for including/exculding resolved alerts in the response's payload
- Add default query filters to the assets requests
- Add default query filters to the alerts requests
Add release notes
e417f3a
@YuvHayun
Copy link
Contributor

Demo summary:
We should differentiate between the cases where the list command is used for fetch-alerts purposes and between the cases where the list command is used as a stand-alone command.
In the case where it's used as a part of the fetch-alerts command, we should use the integration param, while in the standalone command we should be able to decide whether include/exclude the resolved alerts by using a boolean argument.
Also make sure to add this to the integration yml file, README file, and release note.

@YuvHayun YuvHayun added post-demo and removed pending-demo Demo pending labels Sep 18, 2022
Hezi and others added 2 commits September 18, 2022 15:54
@YuvHayun YuvHayun merged commit 8159077 into demisto:contrib/heziclaroty_claroty/add-query-filters-to-alerts-and-assets-requests Sep 19, 2022
@content-bot content-bot mentioned this pull request Sep 19, 2022
Merged
10 tasks
YuvHayun added a commit that referenced this pull request Sep 19, 2022
@content-bot @YuvHayun
Add query filters to requests (#21311)
eb070d0 
* Add query filters to requests (#21076)

* Add query filters to requsets

- Add a new field to configuration form for including/exculding resolved alerts in the response's payload
- Add default query filters to the assets requests
- Add default query filters to the alerts requests

* Add release notes

* Add exclude-resolved-alerts as args to query-alerts command

* fixes

Co-authored-by: heziclaroty <112946953+heziclaroty@users.noreply.github.com>
Co-authored-by: YuvHayun <yhayun@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@YuvHayun YuvHayun

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved pending-contributor The PR is pending the response of its creator post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CLAassistant @content-bot @YuvHayun