Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gmail Single User - add support in credential store #23511

Merged
merged 7 commits into from
Jan 10, 2023

Conversation

mmhw
Copy link
Contributor

@mmhw mmhw commented Jan 3, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Relates: link to the issue

Description

Change the type of credentials, from type 4 to type 9.

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@mmhw mmhw self-assigned this Jan 3, 2023
@mmhw mmhw requested a review from bziser January 4, 2023 10:34
@guardrails
Copy link

guardrails bot commented Jan 9, 2023

⚠️ We detected 2 security issues in this pull request:

Hard-Coded Secrets (2)
Docs Details
💡 Title: Secret Keyword, Severity: Medium
💡 Title: Secret Keyword, Severity: Medium
displaypassword: "Auth Code (run the !gmail-auth-link command to start the auth flow - see Help section)"

More info on how to fix Hard-Coded Secrets in General.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@xsoar-bot
Copy link
Contributor

@mmhw mmhw merged commit 6f149b6 into master Jan 10, 2023
@mmhw mmhw deleted the MW_GmailSingleUser_add_support_in_credential_store branch January 10, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants