added support for xsiam #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to also update release notes and main README. |
Itay4
reviewed
Mar 14, 2022
CHANGELOG.md
Outdated
| @@ -4,6 +4,9 @@ | |||
|
|
|||
| [1]: https://pypi.org/project/demisto-py/#history | |||
|
|
|||
| ## 3.1.2 | |||
| * Added auth_id to support `XSIAM` instances. | |||
There was a problem hiding this comment.
Suggested change
| * Added auth_id to support `XSIAM` instances. | |
| * Add support to Cortex XSIAM. |
Itay4
reviewed
Mar 14, 2022
README.md
Outdated
| @@ -25,6 +25,7 @@ as the following environment variables (env variables will be used if parameters | |||
| * DEMISTO_API_KEY | |||
| * DEMISTO_USERNAME | |||
| * DEMISTO_PASSWORD | |||
| * DEMISTO_AUTH_ID (for XSIAM, If is set it means we should use the XSIAM api) | |||
There was a problem hiding this comment.
i think the env var should be named XSIAM_AUTH_ID
Itay4
reviewed
Mar 14, 2022
README.md
Outdated
| @@ -25,6 +25,7 @@ as the following environment variables (env variables will be used if parameters | |||
| * DEMISTO_API_KEY | |||
| * DEMISTO_USERNAME | |||
| * DEMISTO_PASSWORD | |||
| * DEMISTO_AUTH_ID (for XSIAM, If is set it means we should use the XSIAM api) | |||
There was a problem hiding this comment.
Suggested change
| * DEMISTO_AUTH_ID (for XSIAM, If is set it means we should use the XSIAM api) | |
| * DEMISTO_AUTH_ID (for Cortex XSIAM only. If set, Cortex XSIAM API will be used) |
Itay4
reviewed
Mar 14, 2022
README.md
Outdated
| @@ -41,7 +42,20 @@ api_instance = demisto_client.configure(base_url=host, api_key=api_key) | |||
|
|
|||
| ``` | |||
|
|
|||
| **Alternatively, you can login with username and password:** | |||
| **on the XSIAM we nead to add the auth_id** | |||
There was a problem hiding this comment.
Suggested change
| **on the XSIAM we nead to add the auth_id** | |
| **For Cortex XSIAM, we need to set the auth_id** |
Itay4
reviewed
Mar 14, 2022
README.md
Outdated
| ```python | ||
| import demisto_client | ||
|
|
||
| # Also possible to set env variables: DEMISTO_API_KEY and DEMISTO_BASE_URL |
There was a problem hiding this comment.
add note here about the possible env var
Itay4
reviewed
Mar 16, 2022
demisto_client/__init__.py
Outdated
| if isinstance(configuration.host, str): | ||
| configuration.host = configuration.host.rstrip('/') | ||
| if auth_id: | ||
| configuration.api_key['x-xdr-auth-id'] = auth_id | ||
| configuration.host = f'{configuration.host}/xsoar' |
There was a problem hiding this comment.
use os.path.join to avoid issues with trailing slash
Itay4
approved these changes
Mar 16, 2022
Itay4
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready/In Progress/In Hold (Reason for hold)
Related Issues
fixes: https://github.com/demisto/etc/issues/46625
Description
A few sentences describing the overall goals of the pull request's commits.
Must have