-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for xsiam #80
Conversation
Need to also update release notes and main README. |
CHANGELOG.md
Outdated
@@ -4,6 +4,9 @@ | |||
|
|||
[1]: https://pypi.org/project/demisto-py/#history | |||
|
|||
## 3.1.2 | |||
* Added auth_id to support `XSIAM` instances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Added auth_id to support `XSIAM` instances. | |
* Add support to Cortex XSIAM. |
README.md
Outdated
@@ -25,6 +25,7 @@ as the following environment variables (env variables will be used if parameters | |||
* DEMISTO_API_KEY | |||
* DEMISTO_USERNAME | |||
* DEMISTO_PASSWORD | |||
* DEMISTO_AUTH_ID (for XSIAM, If is set it means we should use the XSIAM api) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the env var should be named XSIAM_AUTH_ID
README.md
Outdated
@@ -25,6 +25,7 @@ as the following environment variables (env variables will be used if parameters | |||
* DEMISTO_API_KEY | |||
* DEMISTO_USERNAME | |||
* DEMISTO_PASSWORD | |||
* DEMISTO_AUTH_ID (for XSIAM, If is set it means we should use the XSIAM api) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* DEMISTO_AUTH_ID (for XSIAM, If is set it means we should use the XSIAM api) | |
* DEMISTO_AUTH_ID (for Cortex XSIAM only. If set, Cortex XSIAM API will be used) |
README.md
Outdated
@@ -41,7 +42,20 @@ api_instance = demisto_client.configure(base_url=host, api_key=api_key) | |||
|
|||
``` | |||
|
|||
**Alternatively, you can login with username and password:** | |||
**on the XSIAM we nead to add the auth_id** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**on the XSIAM we nead to add the auth_id** | |
**For Cortex XSIAM, we need to set the auth_id** |
README.md
Outdated
```python | ||
import demisto_client | ||
|
||
# Also possible to set env variables: DEMISTO_API_KEY and DEMISTO_BASE_URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add note here about the possible env var
demisto_client/__init__.py
Outdated
if isinstance(configuration.host, str): | ||
configuration.host = configuration.host.rstrip('/') | ||
if auth_id: | ||
configuration.api_key['x-xdr-auth-id'] = auth_id | ||
configuration.host = f'{configuration.host}/xsoar' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use os.path.join
to avoid issues with trailing slash
Status
Ready/In Progress/In Hold (Reason for hold)
Related Issues
fixes: https://github.com/demisto/etc/issues/46625
Description
A few sentences describing the overall goals of the pull request's commits.
Must have