Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not decode application/gzip response #86

Merged
merged 13 commits into from
Apr 3, 2022

Conversation

MosheEichler
Copy link
Contributor

@MosheEichler MosheEichler commented Mar 29, 2022

Status

Ready

Related Issues

fixes: https://github.com/demisto/etc/issues/47661

Description

Added the application/gzip in content-type response to avoid decoding

Must have

  • Unit Test or Example Code
  • Changelog entry

@MosheEichler MosheEichler self-assigned this Mar 29, 2022
Copy link
Collaborator

@amshamah419 amshamah419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change needs to be done in this file.

https://github.com/demisto/demisto-py/blob/master/gen-code.sh

Use a sed command to make the change. Since this is generated code, if we don't put the bug fix in the generator, next time it's ran, it could be removed.

@MosheEichler MosheEichler changed the title add try except do not decode application/gzip response Mar 30, 2022
@dorschw dorschw removed their request for review March 31, 2022 15:04
@yaakovi
Copy link
Contributor

yaakovi commented Apr 3, 2022

@amshamah419 please review the recent changes

@yaakovi yaakovi removed their request for review April 3, 2022 05:01
Copy link
Collaborator

@amshamah419 amshamah419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MosheEichler MosheEichler merged commit ef515ab into master Apr 3, 2022
@MosheEichler MosheEichler deleted the disable_decoding_to_utf-8 branch April 3, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants