Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding slices #173

Closed
wants to merge 5 commits into from
Closed

Conversation

djdiskmachine
Copy link
Contributor

Rebased on master
Issue when loading project "restoring allocation" whenever 164-170 are added

Rebased on master
Issue when loading project "restoring allocation" whenever 164-170 are added
Copy link
Collaborator

@democloid democloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the crash, have you tried to create a new project to test this?

sources/Application/Instruments/SampleInstrument.h Outdated Show resolved Hide resolved
sources/Application/Views/InstrumentView.cpp Show resolved Hide resolved
djdiskmachine added 4 commits April 3, 2024 14:43
Show or hide slices field by refreshing instrument screen when changing loop mode
@djdiskmachine
Copy link
Contributor Author

@democloid rootnote will still affect the playback pitch. I made the implementation to be the same as on M8tracker, setting the first slice to C3 will make 48 the max number of slices. :)

@djdiskmachine
Copy link
Contributor Author

@democloid is this still relevant or should i delete it?

@maks
Copy link
Collaborator

maks commented Sep 18, 2024

@djdiskmachine please dont delete it! I'd really love to have slicing support in pT!
Sorry about this sitting untouched for so long! It will likely need a bit of rework onto the changes that are being done in the pT codebase, but I'm happy to put my hand up to help out with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants