[code] polish all libraries to meet ESLint specifications.

[santisiri]

All code must meet ESLint specifications, set to Airbnb best practice standards.

If you're using Atom we suggest adding a package like Linter Eslint to keep track of coding guidelines. This will enhance collaboration quality of overall project.

Kudos to @LucasIsasmendi for this.

[virgile-dev]

@santisiri @LucasIsasmendi where are we at with this ?

[daidoji]

I wasn't sure where to start and the slack channel led me to believe I'd have more luck here than elsewhere. Are the tests supposed to fail on staging and master? Mainly they look like linter failures but I wanted to make sure I was starting from the right place as I support the project and want to contribute?

Two files attached with me checking out staging and running tests (similar results on master). Perhaps these aren't critical failures due to the fact that this issue is still open?? Also would love to learn more about the communication and development process on this app as the slack and gitter channels seem dead for the most part.

Here are the files that are output from running the commands meteor npm run test and meteor npm run test-app as suggested in CONTRIBUTING.md. If these aren't fatal errors please let me know.

npm_run_test-app.log
npm_run_test.log

[medied]

Slack has been somewhat quite but it can work as a via of communication. Thanks @daidoji for looking into this, this can be a good way to start getting to know the codebase. staging branch we are not currently using, master is the main one

[daidoji]

Got an issue. Not sure how Spinner can be defined if its not imported or instantiated. Maybe someone who understands this part can point it out to me???

sovereign/imports/ui/templates/widgets/spinner/spinner.js
45:11 error 'spinner' is assigned a value but never used no-unused-vars
45:25 error 'Spinner' is not defined no-undef