Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for i18n of the landing page content #5

Open
juho-jaakkola opened this issue Sep 14, 2016 · 6 comments
Open

Add support for i18n of the landing page content #5

juho-jaakkola opened this issue Sep 14, 2016 · 6 comments

Comments

@juho-jaakkola
Copy link
Contributor

Currently the page contents are the same regardless of which language the UI is using.

This is something that would ideally be fixed in Elgg core, but temporary workarounds are welcome.

@demyxco
Copy link
Owner

demyxco commented Sep 14, 2016

True. Feel free to add the setting content in the language.php file.

@juho-jaakkola
Copy link
Contributor Author

Well, then there is no point in having a setting in the first place. :) (Which I personally do not mind, because I prefer doing stuff through code instead of settings in the first place.)

@demyxco
Copy link
Owner

demyxco commented Sep 14, 2016

What about the people who don't know how to code? Lol.

@demyxco
Copy link
Owner

demyxco commented Nov 30, 2016

Hey I was just wondering, doesn't Elgg handle i18n? Or did I not create a en.php file?

@juho-jaakkola
Copy link
Contributor Author

I'm not sure what you mean.

Elgg does handle i18n when the elgg_echo() function is used, but not when the string comes from a plugin setting. This is why I think it would be better if the landing page contents would come from a translations file instead of plugin settings.

@demyxco
Copy link
Owner

demyxco commented Dec 11, 2016

Oh yeah, I need to update that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants