Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check in tools for generating generated_* files #33

Open
GoogleCodeExporter opened this issue Jul 6, 2015 · 2 comments
Open

Check in tools for generating generated_* files #33

GoogleCodeExporter opened this issue Jul 6, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

There's a lot of data files that get generated, such as 
cld_generated_cjk_uni_prop_80.cc and its ilk. There have been several problems 
in the past with the generated files that have necessitated post-generation 
fixes, e.g.:

https://code.google.com/p/cld2/source/detail?r=155
https://code.google.com/p/cld2/source/detail?r=156
https://code.google.com/p/cld2/source/detail?r=189
https://code.google.com/p/cld2/source/detail?r=192
https://code.google.com/p/cld2/source/detail?r=193

...

And now we have issue 32, which is more of the same. We don't have the 
templates or whatever are used to generated these source files checked in; we 
should. I get that the actual data is huge and isn't something we'd store in 
Git, but I'd really like to see us put the templates/generators into the code 
base so that we can maintain them alongside the code that they produce.

High priority because I feel that at this point there is likely drift between 
the templates and the code they produce; we should probably get the templates 
checked in and iterate on them until they produce exactly the same files that 
we have today, then proceed forward with maintenance.

WDYT?

Original issue reported on code.google.com by andrewha...@google.com on 1 May 2015 at 8:34

@GoogleCodeExporter
Copy link
Author

Oh, right. I didn't notice (despite it having generated in the name!) that 
cld_generated_cjk_uni_prop_80.cc was generated. Let me know if I can help with 
making/testing a patch to get issue 32 fixed.

Original comment by scottmg@chromium.org on 1 May 2015 at 6:17

@GoogleCodeExporter
Copy link
Author

Original comment by andrewha...@google.com on 11 Jun 2015 at 3:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant