You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's a lot of data files that get generated, such as
cld_generated_cjk_uni_prop_80.cc and its ilk. There have been several problems
in the past with the generated files that have necessitated post-generation
fixes, e.g.:
https://code.google.com/p/cld2/source/detail?r=155
https://code.google.com/p/cld2/source/detail?r=156
https://code.google.com/p/cld2/source/detail?r=189
https://code.google.com/p/cld2/source/detail?r=192
https://code.google.com/p/cld2/source/detail?r=193
...
And now we have issue 32, which is more of the same. We don't have the
templates or whatever are used to generated these source files checked in; we
should. I get that the actual data is huge and isn't something we'd store in
Git, but I'd really like to see us put the templates/generators into the code
base so that we can maintain them alongside the code that they produce.
High priority because I feel that at this point there is likely drift between
the templates and the code they produce; we should probably get the templates
checked in and iterate on them until they produce exactly the same files that
we have today, then proceed forward with maintenance.
WDYT?
Original issue reported on code.google.com by andrewha...@google.com on 1 May 2015 at 8:34
Oh, right. I didn't notice (despite it having generated in the name!) that
cld_generated_cjk_uni_prop_80.cc was generated. Let me know if I can help with
making/testing a patch to get issue 32 fixed.
Original comment by scottmg@chromium.org on 1 May 2015 at 6:17
Original issue reported on code.google.com by
andrewha...@google.com
on 1 May 2015 at 8:34The text was updated successfully, but these errors were encountered: