Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fish widget code #671

Merged
merged 8 commits into from
Jan 17, 2022
Merged

Improve fish widget code #671

merged 8 commits into from
Jan 17, 2022

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Jan 16, 2022

  • Remove unused code

  • Replace [ with idiomatic test. fish's manpage says:

    The first form (test) is preferred. For compatibility with other shells, the
    second form is available: a matching pair of square brackets ([ [EXPRESSION ] ]).

  • Prepend underscore to widget function to avoid name clashing

  • Insert command instead of replacing, when not doing smart replace

  • Only bind insert mode when not using default keybindings

  • Correctly quote variables to support multiline commands

@welcome
Copy link

welcome bot commented Jan 16, 2022

Thanks for opening this pull request!

@kidonng kidonng marked this pull request as ready for review January 16, 2022 17:42
@denisidoro denisidoro merged commit b556808 into denisidoro:master Jan 17, 2022
@welcome
Copy link

welcome bot commented Jan 17, 2022

Congrats on merging your first pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants