Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: A one query method to cover all of them #49

Open
halvardssm opened this issue May 29, 2020 · 1 comment
Open

Request: A one query method to cover all of them #49

halvardssm opened this issue May 29, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@halvardssm
Copy link
Collaborator

Hi! I really appreciate the work you have put into this library!

When automating queries it's not always possible to know if a request will be a query or an execution. Would it be possible to have one method exposed which handles any type of query? Currently, if I use execute, it will throw an error if the response is empty (e.g. from a select statement), and if I use query it will time out if I use an insert/delete/update statement. Maybe changing execute to not throw on empty but rather return undefined or null would be an option?

Thanks!

@manyuanrong
Copy link
Member

For ease of use, this is a point worth considering, I will add it to the future list

@manyuanrong manyuanrong added the enhancement New feature or request label Jun 1, 2020
@manyuanrong manyuanrong added this to the future milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants