Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider interpreting a Null Array as null rather than an empty array #316

Closed
uki00a opened this issue Jun 13, 2022 · 0 comments · Fixed by #321
Closed

Consider interpreting a Null Array as null rather than an empty array #316

uki00a opened this issue Jun 13, 2022 · 0 comments · Fixed by #321
Assignees
@uki00a
Labels
bug Something isn't working

Comments

@uki00a
Copy link
Member

uki00a commented Jun 13, 2022 •
edited
Loading

Currently, deno-redis treats the following reply as an empty array:

"*-1\r\n"

deno-redis might treat this as null, as drivers in other languages do 🤔

Ref: https://github.com/redis/redis-doc/blob/b93a6dcf572fb11cc03c0feb3e82366d39656835/docs/reference/protocol-spec.md#resp-arrays
@uki00a uki00a added the bug Something isn't working label Jun 13, 2022
@uki00a uki00a self-assigned this Jun 13, 2022
@uki00a uki00a changed the title Consider interpreting Null Arrays as null rather than an empty array Consider interpreting a Null Array as null rather than an empty array Jun 13, 2022
@uki00a uki00a changed the title Consider interpreting a Null Array as null rather than an empty array Consider interpreting a Null Array as null rather than an empty array Jun 13, 2022
@uki00a uki00a mentioned this issue Jul 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uki00a uki00a

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING: Treat null arrays as BulkNil instead of the empty array
1 participant
@uki00a