Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

bug: non root html emit does not work #16

Closed
lucacasonato opened this issue Sep 7, 2020 · 1 comment · Fixed by #20
Closed

bug: non root html emit does not work #16

lucacasonato opened this issue Sep 7, 2020 · 1 comment · Fixed by #20
Assignees
Labels
bug Something isn't working

Comments

@lucacasonato
Copy link
Collaborator

A config that emits a HTML file like so:

    html({
      template: createHtmlTemplate,
      title: "React App",
      meta: [
        { charset: "utf-8" },
        {
          name: "viewport",
          content: "width=device-width, initial-scale=1",
        },
        {
          name: "description",
          content: "Web site created using create-react-app",
        },
      ],
      fileName: "x/test.html",
    }),

leads to three issues:

  1. The emitted <script src="mod.js" type="module"></script> should look like <script src="../mod.js" type="module"></script>
  2. The emitted <link href="mod.css" rel="stylesheet"> should look like <link href="../mod.css" rel="stylesheet">
  3. mkdir -r dist/x has to be run before denopack, because denopack does not create the directory itself.

Meta

> denopack --version
denopack/0.8.0 linux-x86_64 deno-1.3.3
@lucacasonato lucacasonato added the bug Something isn't working label Sep 7, 2020
@Soremwar
Copy link
Collaborator

Soremwar commented Sep 7, 2020

@jeroenptrs Dibs on this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants