Upgrade V8 to (kKeep fix)

#814 https://bugs.chromium.org/p/v8/issues/detail?id=8761 Use kKeep Upgrade V8 to 7.4.98
denoland · Feb 7, 2019 · 27a7daa · 27a7daa
1 parent 39429a2
commit 27a7daa
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 6 deletions.
diff --git a/build b/build
diff --git a/gclient_config.py b/gclient_config.py
@@ -1,6 +1,7 @@
 # Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
 solutions = [{
-    'url': 'https://chromium.googlesource.com/v8/v8.git@7.2.502.16',
+    'url':
+    'https://chromium.googlesource.com/v8/v8.git@7.4.98',
     'name': 'v8',
     'deps_file': 'DEPS',
     'custom_deps': {

diff --git a/libdeno/api.cc b/libdeno/api.cc
@@ -84,7 +84,7 @@ deno_buf deno_get_snapshot(Deno* d_) {
   d->context_.Reset();
 
   auto blob = d->snapshot_creator_->CreateBlob(
-      v8::SnapshotCreator::FunctionCodeHandling::kClear);
+      v8::SnapshotCreator::FunctionCodeHandling::kKeep);
   return {nullptr, 0, reinterpret_cast<uint8_t*>(const_cast<char*>(blob.data)),
           blob.raw_size};
 }

diff --git a/tests/error_004_missing_module.ts.out b/tests/error_004_missing_module.ts.out
@@ -7,6 +7,7 @@ Uncaught NotFound: Cannot resolve module "bad-module.ts" from "[WILDCARD]/tests/
     at sendSync ([WILDCARD]/js/dispatch.ts:[WILDCARD])
     at codeFetch ([WILDCARD]/js/os.ts:[WILDCARD])
     at _resolveModule ([WILDCARD]/js/compiler.ts:[WILDCARD])
+    at [WILDCARD]/js/compiler.ts:[WILDCARD]
     at resolveModuleNames ([WILDCARD]/js/compiler.ts:[WILDCARD])
     at compilerHost.resolveModuleNames ([WILDCARD]typescript.js:[WILDCARD])
     at resolveModuleNamesWorker ([WILDCARD]typescript.js:[WILDCARD])

diff --git a/tests/error_005_missing_dynamic_import.ts.out b/tests/error_005_missing_dynamic_import.ts.out
@@ -5,6 +5,7 @@
     at sendSync ([WILDCARD]/js/dispatch.ts:[WILDCARD])
     at codeFetch ([WILDCARD]/js/os.ts:[WILDCARD])
     at _resolveModule ([WILDCARD]/js/compiler.ts:[WILDCARD])
+    at [WILDCARD]/js/compiler.ts:[WILDCARD]
     at resolveModuleNames ([WILDCARD]/js/compiler.ts:[WILDCARD])
     at compilerHost.resolveModuleNames ([WILDCARD])
     at resolveModuleNamesWorker ([WILDCARD])

diff --git a/tests/error_006_import_ext_failure.ts.out b/tests/error_006_import_ext_failure.ts.out
@@ -7,6 +7,7 @@ Uncaught NotFound: Cannot resolve module "./non-existent" from "[WILDCARD]/tests
     at sendSync ([WILDCARD]/js/dispatch.ts:[WILDCARD])
     at codeFetch ([WILDCARD]/js/os.ts:[WILDCARD])
     at _resolveModule ([WILDCARD]/js/compiler.ts:[WILDCARD])
+    at [WILDCARD]/js/compiler.ts:[WILDCARD]
     at resolveModuleNames ([WILDCARD]/js/compiler.ts:[WILDCARD])
     at compilerHost.resolveModuleNames ([WILDCARD])
     at resolveModuleNamesWorker ([WILDCARD])

diff --git a/third_party b/third_party
diff --git a/tools/third_party.py b/tools/third_party.py
@@ -255,8 +255,7 @@ def download_clang_format():
 
 # Download clang by calling the clang update script.
 def download_clang():
-    run(['python',
-         tp('v8/tools/clang/scripts/update.py'), '--if-needed'],
+    run(['python', tp('v8/tools/clang/scripts/update.py')],
         env=google_env())