Skip to content

Commit

Permalink
ci: fix rusty_v8 binary download unavailable (#7898)
Browse files Browse the repository at this point in the history
A recent change in rustc or cargo made it so that rusty_v8's `build.rs`,
which is responsible for downloading `librusty_v8.a`, does not get
rebuilt or re-run when its build output directory is restored from the
Github Actions cache.

However, rusty_v8's custom build script does not save the download to
its build output directory; it puts the file in
`target/debug|release/gn_out/obj` instead.

To get CI going again we opted to add `target/*/gn_out` to the Github
Actions cache.

A more robust fix would be make rusty_v8 save the download to the
cargo-designated output directory.
  • Loading branch information
piscisaureus committed Oct 9, 2020
1 parent 2ae5931 commit f911dc3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ jobs:
target/*/.*
target/*/build
target/*/deps
target/*/gn_out
key: deno-${{ matrix.os }}-${{ matrix.kind }}-${{ hashFiles('Cargo.lock') }}
restore-keys: |
deno-${{ matrix.os }}-${{ matrix.kind }}-
Expand Down

0 comments on commit f911dc3

Please sign in to comment.