Fix CI two times #7898
Merged
Fix CI two times #7898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change in rustc or cargo made it so that rusty_v8's `build.rs`, which is responsible for downloading `librusty_v8.a`, does not get rebuilt or re-run when its build output directory is restored from the Github Actions cache. However, rusty_v8's custom build script does not save the download to its build output directory; it puts the file in `target/debug|release/gn_out/obj` instead. To get CI going again we opted to add `target/*/gn_out` to the Github Actions cache. A more robust fix would be make rusty_v8 save the download to the cargo-designated output directory.
piscisaureus
changed the title
piscisaureus
added a commit
that referenced
this pull request
Oct 9, 2020
piscisaureus
added a commit
that referenced
this pull request
Oct 9, 2020
piscisaureus
added a commit
that referenced
this pull request
Oct 9, 2020
piscisaureus
added a commit
that referenced
this pull request
Oct 9, 2020
piscisaureus
added a commit
that referenced
this pull request
Oct 9, 2020
piscisaureus
added a commit
that referenced
this pull request
Oct 9, 2020
piscisaureus
added a commit
that referenced
this pull request
Oct 9, 2020
piscisaureus
added a commit
that referenced
this pull request
Oct 9, 2020
piscisaureus
added a commit
that referenced
this pull request
Oct 9, 2020
piscisaureus
added a commit
that referenced
this pull request
Oct 9, 2020
piscisaureus
added a commit
that referenced
this pull request
Oct 9, 2020
ry
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
I did an analysis of the speed up we're getting from cache in #7903 (comment) . It's not much. I would say if we run into more bugs or have to introduce more complexity, it would be probably better to simply remove the whole thing.
But it seems like this is working and is faster so LGTM. Thanks for putting out this fire.
It's a lot of stuff for a few minutes gain. Maybe this experience will give us some hints on why our builds are so slow (and caching not effective) and it can be improved. If not I agree then let's just turn it off. BTW from-scratch release build & run tests in 10 minutes! |
iykekings
pushed a commit
to iykekings/deno
that referenced
this pull request
Oct 10, 2020
A recent change in rustc or cargo made it so that rusty_v8's `build.rs`, which is responsible for downloading `librusty_v8.a`, does not get rebuilt or re-run when its build output directory is restored from the Github Actions cache. However, rusty_v8's custom build script does not save the download to its build output directory; it puts the file in `target/debug|release/gn_out/obj` instead. To get CI going again we opted to add `target/*/gn_out` to the Github Actions cache. A more robust fix would be make rusty_v8 save the download to the cargo-designated output directory.
iykekings
pushed a commit
to iykekings/deno
that referenced
this pull request
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.