Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unstable "Deno.upgradeHttp" API #21828

Closed
bartlomieju opened this issue Jan 6, 2024 · 0 comments · Fixed by #21856
Closed

Remove unstable "Deno.upgradeHttp" API #21828

bartlomieju opened this issue Jan 6, 2024 · 0 comments · Fixed by #21856

Comments

@bartlomieju
Copy link
Member

This API only works with "Deno.serveHttp()" which is deprecated and "Deno.serve()" should be used instead.
@bartlomieju bartlomieju changed the title Remove unstable "Deno.upgradeWebsocket" API Remove unstable "Deno.upgradeHttp" API Jan 8, 2024
@bartlomieju bartlomieju mentioned this issue Jan 8, 2024
Merged
bartlomieju added a commit that referenced this issue Jan 22, 2024
@bartlomieju
feat(unstable): remove Deno.upgradeHttp API (#21856)
71551c8 
Closes #21828.

This API is a huge footgun. And given that "Deno.serveHttp" is a
deprecated API that is discouraged to use (use "Deno.serve()" 
instead); it makes no sense to keep this API around.

This is a step towards fully migrating to Hyper 1.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(unstable): remove Deno.upgradeHttp API bartlomieju/deno
1 participant
@bartlomieju