Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPT] actions workflow wpt_epoch.yml is failing #22257

Closed
panva opened this issue Feb 4, 2024 · 2 comments · Fixed by #22312 or #22550
Closed

[WPT] actions workflow wpt_epoch.yml is failing #22257

panva opened this issue Feb 4, 2024 · 2 comments · Fixed by #22312 or #22550

Comments

@panva
Copy link
Contributor

panva commented Feb 4, 2024

Since Jan 26 2024 this workflow is failing and results are no longer submitted to wpt.fyi for aligned comparisons.

@bartlomieju
Copy link
Member

Thanks for flagging this @panva, this should be fixed by #22312.

bartlomieju added a commit that referenced this issue Feb 7, 2024
littledivy pushed a commit that referenced this issue Feb 8, 2024
@panva
Copy link
Contributor Author

panva commented Feb 8, 2024

@littledivy littledivy reopened this Feb 8, 2024
bartlomieju pushed a commit that referenced this issue Feb 23, 2024
Having `|| true` means that the job always executes with a success code,
even when it really fails. Credit to Bartek for spotting this possible
mistake.

Towards #22257
mmastrac added a commit that referenced this issue Feb 26, 2024
Should fix #22257

---------

Co-authored-by: Matt Mastracci <matthew@mastracci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants