Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test sanitizers when using node:test? #22473

Closed
dsherret opened this issue Feb 19, 2024 · 3 comments · Fixed by #22480
Closed

Disable test sanitizers when using node:test? #22473

dsherret opened this issue Feb 19, 2024 · 3 comments · Fixed by #22480
Labels
suggestion suggestions for new features (yet to be agreed)

Comments

@dsherret
Copy link
Member

dsherret commented Feb 19, 2024

For better Node compat, perhaps the test sanitizers should be disabled when using node:test since node:test doesn't have this behaviour?

#22471

@mmastrac
Copy link
Member

I think this makes sense.

@77it
Copy link

77it commented Feb 19, 2024

I'm writing code on Deno that can work also with Node, but I dislike the idea of having tests working differently under Deno just because I use node:test instead of Deno.test(). I could understand a switch/option or whatever makes explicit the difference and leave me choice. I like the strictness of Deno, when is needed/useful to produce better code.

@dsherret
Copy link
Member Author

dsherret commented Feb 19, 2024

but I dislike the idea of having tests working differently under Deno just because I use node:test instead of Deno.test()

I think a bigger problem is having node:test work differently under Deno than Node unfortunately. The node:test API doesn't have sanitizers.

I'm writing code on Deno that can work also with Node

You may wish to create your own test function that internally calls Deno.test in Deno and then node:test in Node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants