Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node/test): disable Deno test sanitizers #22480

Merged
merged 2 commits into from Feb 21, 2024
Merged

fix(node/test): disable Deno test sanitizers #22480

merged 2 commits into from Feb 21, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 19, 2024 •
edited

Closes #22473

@dsherret dsherret marked this pull request as ready for review February 19, 2024 15:02
mmastrac
mmastrac approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 6592a92 into denoland:main Feb 21, 2024
17 of 20 checks passed
@dsherret dsherret deleted the fix_disable_sanitizers_node_test branch February 21, 2024 04:22
@mmastrac mmastrac mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable test sanitizers when using node:test?
2 participants
@dsherret @mmastrac