Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno publish failed to resolve types from import in workspace #22819

Closed
JOTSR opened this issue Mar 9, 2024 · 1 comment · Fixed by #22849
Closed

deno publish failed to resolve types from import in workspace #22819

JOTSR opened this issue Mar 9, 2024 · 1 comment · Fixed by #22849
Assignees
Labels
bug Something isn't working correctly publish Related to "deno publish" subcommand

Comments

@JOTSR
Copy link
Contributor

JOTSR commented Mar 9, 2024

Version: Deno 1.41.2

Currently porting cliffy to jsr (commit 587cfd1).
While running deno publish --dry-run on cliffy PR#679, types imported in @cliffy/command/type.ts failed check on deno publish --dry-run.

error: Failed ensuring public API type output is valid.

TS2304 [ERROR]: Cannot find name 'ArgumentValue'.
  public abstract parse(type: ArgumentValue): TValue;
                              ~~~~~~~~~~~~~
    at file:///.../deno-cliffy/command/type.ts:35:31

TS2304 [ERROR]: Cannot find name 'Command'.
   */ public values?(cmd: Command, parent?: Command): ValuesHandlerResult;
                          ~~~~~~~
    at file:///.../deno-cliffy/command/type.ts:42:10

TS2304 [ERROR]: Cannot find name 'Command'.
   */ public values?(cmd: Command, parent?: Command): ValuesHandlerResult;
                                            ~~~~~~~
    at file:///.../deno-cliffy/command/type.ts:43:14

TS2304 [ERROR]: Cannot find name 'ValuesHandlerResult'.
   */ public values?(cmd: Command, parent?: Command): ValuesHandlerResult;
                                                      ~~~~~~~~~~~~~~~~~~~
    at file:///.../deno-cliffy/command/type.ts:44:6

TS2304 [ERROR]: Cannot find name 'Command'.
   */ public complete?(cmd: Command, parent?: Command): CompleteHandlerResult;
                            ~~~~~~~
    at file:///.../deno-cliffy/command/type.ts:51:10

TS2304 [ERROR]: Cannot find name 'Command'.
   */ public complete?(cmd: Command, parent?: Command): CompleteHandlerResult;
                                              ~~~~~~~
    at file:///.../deno-cliffy/command/type.ts:52:14

TS2304 [ERROR]: Cannot find name 'CompleteHandlerResult'.
   */ public complete?(cmd: Command, parent?: Command): CompleteHandlerResult;
                                                        ~~~~~~~~~~~~~~~~~~~~~
    at file:///.../deno-cliffy/command/type.ts:53:6

Found 7 errors.

You may have discovered a bug in Deno. Please open an issue at: https://github.com/denoland/deno/issues/
@dsherret dsherret self-assigned this Mar 9, 2024
@dsherret dsherret added bug Something isn't working correctly publish Related to "deno publish" subcommand labels Mar 9, 2024
@dsherret
Copy link
Member

dsherret commented Mar 9, 2024

Strange. I'm able to reproduce and see what's happening, but not in a unit test yet. This is definitely a bug and I'll try to fix it over the weekend or on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly publish Related to "deno publish" subcommand
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants