Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expo (React Native) tracking issue #22970

Open
6 of 11 tasks
littledivy opened this issue Mar 18, 2024 · 2 comments
Open
6 of 11 tasks

Expo (React Native) tracking issue #22970

littledivy opened this issue Mar 18, 2024 · 2 comments
Assignees
@littledivy
Labels
bug Something isn't working correctly node API polyfill Related to various "node:*" modules APIs node compat

Comments

@littledivy
Copy link
Member

littledivy commented Mar 18, 2024 •
edited
Loading 

$ deno run -A create-expo-app@latest AwesomeProject/
$ cd AwesomeProject/
$ deno task dev
// deno.jsonc
{
  "unstable": ["unsafe-proto"] // needed because of `typed-array-byte-offset` npm module
}

Blockers:

Non blockers but should be fixed:
@littledivy littledivy added bug Something isn't working correctly node compat node API polyfill Related to various "node:*" modules APIs labels Mar 18, 2024
@littledivy littledivy mentioned this issue Mar 23, 2024
Closed
@littledivy littledivy self-assigned this Mar 23, 2024
@littledivy littledivy mentioned this issue Mar 23, 2024
Merged
EvanBacon pushed a commit to expo/expo that referenced this issue Apr 16, 2024
@littledivy
fix(cli): remove non-standard error.code check (#27822)
b30d376 
`error.code` is non-standard property not part of the URL API. This
fixes compatibility issues with Deno (running Expo via Deno's Node.js
compat layer).

This patch removes the `error.code` check because `new URL()` can only
throw when URL is invalid.

Ref denoland/deno#22970
brentvatne pushed a commit to expo/expo that referenced this issue Apr 16, 2024
@littledivy @brentvatne
fix(cli): remove non-standard error.code check (#27822)
2cbe9ea 
`error.code` is non-standard property not part of the URL API. This
fixes compatibility issues with Deno (running Expo via Deno's Node.js
compat layer).

This patch removes the `error.code` check because `new URL()` can only
throw when URL is invalid.

Ref denoland/deno#22970
@millsp
Copy link

millsp commented Jun 2, 2024

Currently fails with

Task web expo start --web
Starting project at /home/pierre/Throwaway/AwesomeProject
Starting Metro Bundler
Failed to construct transformer:  TypeError: this._child.send is not a function
    at ChildProcessWorker.initialize (file:///home/pierre/Throwaway/AwesomeProject/node_modules/.deno/jest-worker@29.7.0/node_modules/jest-worker/build/workers/ChildProcessWorker.js:169:17)
    at new ChildProcessWorker (file:///home/pierre/Throwaway/AwesomeProject/node_modules/.deno/jest-worker@29.7.0/node_modules/jest-worker/build/workers/ChildProcessWorker.js:100:10)
    at WorkerPool.createWorker (file:///home/pierre/Throwaway/AwesomeProject/node_modules/.deno/jest-worker@29.7.0/node_modules/jest-worker/build/WorkerPool.js:30:12)
    at new BaseWorkerPool (file:///home/pierre/Throwaway/AwesomeProject/node_modules/.deno/jest-worker@29.7.0/node_modules/jest-worker/build/base/BaseWorkerPool.js:55:27)
    at new WorkerPool (file:///home/pierre/Throwaway/AwesomeProject/node_modules/.deno/jest-worker@29.7.0/node_modules/jest-worker/build/WorkerPool.js:18:1)
    at new Worker (file:///home/pierre/Throwaway/AwesomeProject/node_modules/.deno/jest-worker@29.7.0/node_modules/jest-worker/build/index.js:141:26)
    at FileMap._getWorker (file:///home/pierre/Throwaway/AwesomeProject/node_modules/.deno/metro-file-map@0.80.9/node_modules/metro-file-map/src/index.js:560:24)
    at FileMap._processFile (file:///home/pierre/Throwaway/AwesomeProject/node_modules/.deno/metro-file-map@0.80.9/node_modules/metro-file-map/src/index.js:382:21)
    at FileMap._applyFileDelta (file:///home/pierre/Throwaway/AwesomeProject/node_modules/.deno/metro-file-map@0.80.9/node_modules/metro-file-map/src/index.js:482:33)
    at file:///home/pierre/Throwaway/AwesomeProject/node_modules/.deno/metro-file-map@0.80.9/node_modules/metro-file-map/src/index.js:214:20
error: Uncaught Error: Failed to spawn '/home/pierre/.deno/bin/deno': Argument list too long (os error 7)

deno 1.44.0
Ubuntu 24.04 LTS

@theopomies
Copy link

Hi, here are 2 other issues I've encountered:

$> deno task web
[...]
TypeError: Return value from serve handler must be a response or a promise resolving to a response
    at ext:deno_http/00_serve.ts:372:15
    at Object.runMicrotasks (ext:core/01_core.js:691:26)
    at processTicksAndRejections (ext:deno_node/_next_tick.ts:57:10)
    at runNextTicks (ext:deno_node/_next_tick.ts:75:3)
    at eventLoopTick (ext:core/01_core.js:182:21)
Exception in onError while handling exception TypeError: Return value from onError handler must be a response or a promise resolving to a response
    at ext:deno_http/00_serve.ts:381:17
    at Object.runMicrotasks (ext:core/01_core.js:691:26)
    at processTicksAndRejections (ext:deno_node/_next_tick.ts:57:10)
    at runNextTicks (ext:deno_node/_next_tick.ts:75:3)
    at eventLoopTick (ext:core/01_core.js:182:21)
Terminating Deno.serve loop due to unexpected error TypeError: Cannot read properties of undefined (reading 'status')
    at ext:deno_http/00_serve.ts:407:26
    at Object.runMicrotasks (ext:core/01_core.js:691:26)
    at processTicksAndRejections (ext:deno_node/_next_tick.ts:57:10)
    at runNextTicks (ext:deno_node/_next_tick.ts:75:3)
    at eventLoopTick (ext:core/01_core.js:182:21)

And then after Ctrl-C to shutdown:

✖ Failed to stop server
Error: Not implemented: StatWatcher.unref() is not implemented
Error: Not implemented: StatWatcher.unref() is not implemented
    at notImplemented (ext:deno_node/_utils.ts:9:9)
    at StatWatcher.unref (ext:deno_node/_fs/_fs_watch.ts:207:5)
    at FileNotifier.unsubscribe (/Users/theopomies/projects/deno/deno-expo/node_modules/.deno/@expo+cli@0.18.29/node_modules/@expo/cli/src/utils/FileNotifier.ts:78:15)
    at FileNotifier.stopObserving (/Users/theopomies/projects/deno/deno-expo/node_modules/.deno/@expo+cli@0.18.29/node_modules/@expo/cli/src/utils/FileNotifier.ts:57:5)
    at DevServerManager.stopAsync (/Users/theopomies/projects/deno/deno-expo/node_modules/.deno/@expo+cli@0.18.29/node_modules/@expo/cli/src/start/server/DevServerManager.ts:232:22)
    at KeyPressHandler.onPress (/Users/theopomies/projects/deno/deno-expo/node_modules/.deno/@expo+cli@0.18.29/node_modules/@expo/cli/src/start/interface/startInterface.ts:75:34)
    at ReadStream.KeyPressHandler.handleKeypress (/Users/theopomies/projects/deno/deno-expo/node_modules/.deno/@expo+cli@0.18.29/node_modules/@expo/cli/src/start/interface/KeyPressHandler.ts:43:18)
    at ReadStream.emit (ext:deno_node/_stream.mjs:1851:9)
    at addChunk (ext:deno_node/_stream.mjs:2873:16)
    at readableAddChunk (ext:deno_node/_stream.mjs:2847:15)

deno 2.0.0-rc.1 (release candidate, release, aarch64-apple-darwin)
v8 12.9.202.5-rusty
typescript 5.5.2

"expo": "~51.0.28"

Repro is fairly easy:

deno run -A npm:create-expo-app@latest deno-expo
cd deno-expo
deno task web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@littledivy littledivy

Labels
bug Something isn't working correctly node API polyfill Related to various "node:*" modules APIs node compat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@millsp @littledivy @theopomies