Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl::pty_unpaired_braces is flaky #23625

Closed
dsherret opened this issue May 1, 2024 · 1 comment · Fixed by #23812
Closed

repl::pty_unpaired_braces is flaky #23625

dsherret opened this issue May 1, 2024 · 1 comment · Fixed by #23812
Labels
flaky a test is not reliable or determinstic

Comments

@dsherret
Copy link
Member

dsherret commented May 1, 2024

---- repl::pty_unpaired_braces stdout ----
command /Users/runner/work/deno/deno/target/release/deno repl
command cwd /var/folders/bc/7ycrpl196j7dsckgtn2m6g800000gn/T/deno-cli-testxkvw7c
command /Users/runner/work/deno/deno/target/release/deno repl
command cwd /var/folders/bc/7ycrpl196j7dsckgtn2m6g800000gn/T/deno-cli-testsSOJiM
command /Users/runner/work/deno/deno/target/release/deno repl
command cwd /var/folders/bc/7ycrpl196j7dsckgtn2m6g800000gn/T/deno-cli-testEdcILr
------ Start Full Text ------
""
------- End Full Text -------
Next text: ""
thread 'repl::pty_unpaired_braces' panicked at tests/util/server/src/pty.rs:41:11:
Timed out.
stack backtrace:
   0:        0x10b5af8e5 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h46bc8e86d021398c
   1:        0x10b3eee53 - core::fmt::write::h1c24e945c7ef8357
   2:        0x10b5b29ee - std::io::Write::write_fmt::hea454fdd323d68d8
   3:        0x10b5b23b9 - std::sys_common::backtrace::print::hdbfcabb7d363540a
   4:        0x10b5b20c2 - std::panicking::default_hook::***closure***::hecb24382dfeeea98
   5:        0x10b5b1c0e - std::panicking::default_hook::h78dca947ab9e89eb
   6:        0x10b5b2d92 - std::panicking::rust_panic_with_hook::hb83cee65df04957a
   7:        0x10b5b2afc - std::panicking::begin_panic_handler::***closure***::hbe6e44d88f82bc77
   8:        0x10b5b2a89 - std::sys_common::backtrace::__rust_end_short_backtrace::h6560cb9c1f1224c1
   9:        0x10b5b2a76 - _rust_begin_unwind
  10:        0x10c9f8325 - core::panicking::panic_fmt::h2aac8cf45f7ae617
  11:        0x10b6308c3 - test_server::pty::Pty::new::hecd59951dddeeb9c
  12:        0x10b1f207f - core::ops::function::FnOnce::call_once::hf03a90ae6422eb9e
  13:        0x10b5ce782 - test::__rust_begin_short_backtrace::h40ce36891ca37b4e
  14:        0x10b5cb9d1 - test::run_test::***closure***::haa1559c506895862
  15:        0x10b5ceac0 - std::sys_common::backtrace::__rust_begin_short_backtrace::hb20eaca03f887988
  16:        0x10b5ce8f8 - core::ops::function::FnOnce::call_once***vtable.shim***::h1f41e11678d9c890
  17:        0x10b5b4fe9 - std::sys::pal::unix::thread::Thread::new::thread_start::h679ffa03f8a73496
  18:     0x7ff80f9fb1d3 - __pthread_start


failures:
    repl::pty_unpaired_braces

https://github.com/denoland/deno/actions/runs/8904067867/job/24452793475

@dsherret dsherret added the flaky a test is not reliable or determinstic label May 1, 2024
@dsherret
Copy link
Member Author

dsherret commented May 1, 2024

I think this would only happen when the CI is very slow.

bartlomieju pushed a commit that referenced this issue May 16, 2024
https://github.com/denoland/deno/actions/runs/9084225162/job/24964698935

```
---- run::file_fetcher_preserves_permissions stdout ----
command /Users/runner/work/deno/deno/target/debug/deno repl --quiet
command cwd /Users/runner/work/deno/deno/tests/testdata
------ Start Full Text ------
"const a = await import('http://localhost:4545/run/019_media_types.ts');\r\n"
------- End Full Text -------
Next text: "\r\n"
thread 'run::file_fetcher_preserves_permissions' panicked at tests/integration/run_tests.rs:4615:15:
Timed out.
```

Closes #23690
Closes #23682
Closes #23625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky a test is not reliable or determinstic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant