Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade_prompt is flaky #23690

Open
dsherret opened this issue May 4, 2024 · 3 comments · Fixed by #23812
Open

upgrade_prompt is flaky #23690

dsherret opened this issue May 4, 2024 · 3 comments · Fixed by #23812
Labels
flaky a test is not reliable or determinstic

Comments

@dsherret
Copy link
Member

dsherret commented May 4, 2024 

---- upgrade::upgrade_prompt stdout ----
command /Users/runner/work/deno/deno/target/debug/deno run --log-level=debug main.js
command cwd /var/folders/bc/7ycrpl196j7dsckgtn2m6g800000gn/T/deno-cli-testLg8NEF
command /Users/runner/work/deno/deno/target/debug/deno run --log-level=debug main.js
command cwd /var/folders/bc/7ycrpl196j7dsckgtn2m6g800000gn/T/deno-cli-testLg8NEF
------ Start Full Text ------
"DEBUG RS - deno::worker:180 - main_module file:///private/var/folders/bc/7ycrpl196j7dsckgtn2m6g800000gn/T/deno-cli-testLg8NEF/main.js\r\nDEBUG RS - deno::module_loader:111 - Preparing module load.\r\nDEBUG RS - deno::module_loader:115 - Building module graph.\r\nDEBUG RS - deno::file_fetcher:565 - FileFetcher::fetch_no_follow_with_options - specifier: file:///private/var/folders/bc/7ycrpl196j7dsckgtn2m6g800000gn/T/deno-cli-testLg8NEF/main.js\r\nDEBUG RS - deno::npm::managed::resolution:313 - Snapshot already up to date. Skipping pending npm resolution.\r\nDEBUG RS - deno::module_loader:165 - Prepared module load.\r\nDEBUG RS - deno_runtime::worker:761 - received module evaluate Ok(\r\n    (),\r\n)\r\nDEBUG RS - deno::module_loader:709 - Updating V8 code cache for ES module: file:///private/var/folders/bc/7ycrpl196j7dsckgtn2m6g800000gn/T/deno-cli-testLg8NEF/main.js, [\"3803688792395291579\"]\r\n"
------- End Full Text -------
Next text: "DEBUG RS - deno::worker:180 - main_module file:///private/var/folders/bc/7ycrpl196j7dsckgtn2m6g800000gn/T/deno-cli-testLg8NEF/main.js\r\nDEBUG RS - deno::module_loader:111 - Preparing module load.\r\nDEBUG RS - deno::module_loader:115 - Building module graph.\r\nDEBUG RS - deno::file_fetcher:565 - FileFetcher::fetch_no_follow_with_options - specifier: file:///private/var/folders/bc/7ycrpl196j7dsckgtn2m6g800000gn/T/deno-cli-testLg8NEF/main.js\r\nDEBUG RS - deno::npm::managed::resolution:313 - Snapshot already up to date. Skipping pending npm resolution.\r\nDEBUG RS - deno::module_loader:165 - Prepared module load.\r\nDEBUG RS - deno_runtime::worker:761 - received module evaluate Ok(\r\n    (),\r\n)\r\nDEBUG RS - deno::module_loader:709 - Updating V8 code cache for ES module: file:///private/var/folders/bc/7ycrpl196j7dsckgtn2m6g800000gn/T/deno-cli-testLg8NEF/main.js, [\"3803688792395291579\"]\r\n"
thread 'upgrade::upgrade_prompt' panicked at tests/integration/upgrade_tests.rs:226:9:

Fails on:

pty.expect_any(&[
      " 99999.99.99 Run `deno upgrade` to install it.",
      // it builds canary releases on main, so check for this in that case
      "Run `deno upgrade --canary` to install it.",
    ]);
@dsherret dsherret added the flaky a test is not reliable or determinstic label May 4, 2024
@dsherret dsherret mentioned this issue May 14, 2024
Merged
dsherret added a commit that referenced this issue May 14, 2024
@dsherret
chore(tests): increase repl timeout on ci (#23812)
1e2b0a2 
https://github.com/denoland/deno/actions/runs/9084225162/job/24964698935

```
---- run::file_fetcher_preserves_permissions stdout ----
command /Users/runner/work/deno/deno/target/debug/deno repl --quiet
command cwd /Users/runner/work/deno/deno/tests/testdata
------ Start Full Text ------
"const a = await import('http://localhost:4545/run/019_media_types.ts');\r\n"
------- End Full Text -------
Next text: "\r\n"
thread 'run::file_fetcher_preserves_permissions' panicked at tests/integration/run_tests.rs:4615:15:
Timed out.
```

Closes #23690
Closes #23682
Closes #23625
bartlomieju pushed a commit that referenced this issue May 16, 2024
@dsherret @bartlomieju
chore(tests): increase repl timeout on ci (#23812)
44cfb4f 
https://github.com/denoland/deno/actions/runs/9084225162/job/24964698935

```
---- run::file_fetcher_preserves_permissions stdout ----
command /Users/runner/work/deno/deno/target/debug/deno repl --quiet
command cwd /Users/runner/work/deno/deno/tests/testdata
------ Start Full Text ------
"const a = await import('http://localhost:4545/run/019_media_types.ts');\r\n"
------- End Full Text -------
Next text: "\r\n"
thread 'run::file_fetcher_preserves_permissions' panicked at tests/integration/run_tests.rs:4615:15:
Timed out.
```

Closes #23690
Closes #23682
Closes #23625
@satyarohith
Copy link
Member

This is still flaky https://github.com/denoland/deno/actions/runs/9123704940/job/25086589350#step:44:2878

@satyarohith satyarohith reopened this May 17, 2024
@bartlomieju
Copy link
Member

Hit another one on the release PR: https://github.com/denoland/deno/actions/runs/9182186013/job/25250567525?pr=23932

@dsherret
Copy link
Member Author

#23933 might fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky a test is not reliable or determinstic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(tests): increase repl timeout on ci dsherret/deno
3 participants
@dsherret @bartlomieju @satyarohith