-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.45.3 breaks proxy env variables impact on deno upgrade
#24691
Comments
Most likely related to #24632 |
Fast ! 🚀 |
Actually the problem is still there in 1.46.0: Pls reopen the issue. See below the error I have:
# deno
BUCKET_ID=$(ls /DATA)
export DENO_INSTALL="/DATA/$BUCKET_ID/.deno"
export DENO_INSTALL_ROOT=$DENO_INSTALL/bin
export DENO_DIR=$DENO_INSTALL/.cache
export DENO_CERT=/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
export DENO_TLS_CA_STORE=system
export PATH="$DENO_INSTALL_ROOT:$PATH"
# proxy
export HTTP_PROXY=xxx
export HTTPS_PROXY=xxx
So for a corp user at the moment the only way to manage upgrades is:
|
I see the error message mentions For example, |
The format I use is For the avoidance of doubt, by url encoded I mean as described here. |
@seanmonstar I guess it might be the same problem as #24705 - I probably missed handling that scenario for |
@oscar6echo I just merged a PR that should fix it. It will be available on canary release in a couple hours. Let me know if that fixes your problem. |
@bartlomieju thx I will try tomorrow morning. Normally I would do This is a bit of a catch 22 situation. |
How to replicate (Linux):
From version 1.45.2 in corp env with env variables
HTTP(S)_PROXY
set dodeno upgrade
.It works and
deno --version
shows new version 1.45.3.Do
deno upgrade
again and the external host is unreachable.I infer that proxy env variables are no longer taken into account (?).
NOTE for other users:
To downgrade to 1.45.2, do
curl -fsSL https://deno.land/install.sh | sh -s v1.0.0
with curl proxy env variableshttp(s)_proxy
set.The text was updated successfully, but these errors were encountered: