-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler APIs should allow a reload
option to cache bust
#5253
Comments
Ref #4752 |
I tried this with Deno 1.5.3. I can confirm that the original complaint was fixed. However, there are a couple of new problems.
Thanks! EDIT: The map file is broken. Now it starts with
I don't know what used to be in there. (I wish I'd saved a copy of the old result or the old Deno executable.) But source maps used to work in Deno 1.5.1. So they must have been relative paths. I'm running the browser on a totally different machine than the Deno server, no file sharing. |
Regarding source maps, they never point at the emitted files, they point back at the source files. Yes previously they could be non-deterministic. Now they point at the absolute URI of the source. It is worth discussing more, but we would likely not address it until #4752. Regarding the name changes, it is intentional, again, because there are all sorts of scenarios where it could be broken if we simply don't append the extension. There is no such thing as a "final form" with an unstable API. 😄 |
Understood. I'm trying to decide how much to fix on my side and how much to wait for. |
Here's my very quick and dirty work around to get source maps working again. I need to do something better, but this works for now and it explains what changed in Deno.
In a *.ts.js file append something like |
Fixes denoland#4743 Closes denoland#5253 Fixes denoland#5631 Fixes denoland#6116 Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com> Co-authored-by: Luca Casonato <lucacasonato@yahoo.com>
Currently there is no way to internally cache bust with the compiler APIs, only if Deno is invoked with
--reload
will the compiler APIs cache bust.The text was updated successfully, but these errors were encountered: