Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reenable upgrade tests #7412

Open
ry opened this issue Sep 10, 2020 · 5 comments
Open

reenable upgrade tests #7412

ry opened this issue Sep 10, 2020 · 5 comments
Labels
tests related to tests

Comments

@ry
Copy link
Member

ry commented Sep 10, 2020 •
edited by lucacasonato
Loading

Upgrade test are flakey since the upgrade to fast runners:

Not sure yet - but I think I've seen this twice now

2020-09-10T13:03:23.5481939Z 
2020-09-10T13:03:23.5483058Z failures:
2020-09-10T13:03:23.5483163Z 
2020-09-10T13:03:23.5483705Z ---- upgrade_in_tmpdir stdout ----
2020-09-10T13:03:23.5483897Z target_dir /home/runner/work/deno/deno/target/release
2020-09-10T13:03:23.5494069Z ##[error]thread 'upgrade_in_tmpdir' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 26, kind: Other, message: "Text file busy" }', cli/tests/integration_tests.rs:417:6
2020-09-10T13:03:23.5498413Z stack backtrace:
2020-09-10T13:03:23.5499326Z    0:     0x55cfbe7ac652 - backtrace::backtrace::libunwind::trace::h14d338b30b3ea0a7
2020-09-10T13:03:23.5499848Z                                at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
2020-09-10T13:03:23.5500656Z    1:     0x55cfbe7ac652 - backtrace::backtrace::trace_unsynchronized::h73ea91d74a3fd67f
2020-09-10T13:03:23.5501365Z                                at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
2020-09-10T13:03:23.5502342Z    2:     0x55cfbe7ac652 - std::sys_common::backtrace::_print_fmt::hd42948c952866e12
2020-09-10T13:03:23.5502560Z                                at src/libstd/sys_common/backtrace.rs:78
2020-09-10T13:03:23.5503315Z    3:     0x55cfbe7ac652 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::ha8f928866ff7571e
2020-09-10T13:03:23.5503530Z                                at src/libstd/sys_common/backtrace.rs:59
2020-09-10T13:03:23.5504200Z    4:     0x55cfbe743c5c - core::fmt::write::he0c1e5f7426d2718
2020-09-10T13:03:23.5504405Z                                at src/libcore/fmt/mod.rs:1076
2020-09-10T13:03:23.5505258Z    5:     0x55cfbe7f0924 - std::io::Write::write_fmt::h1152922039931516
2020-09-10T13:03:23.5505664Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/io/mod.rs:1537
2020-09-10T13:03:23.5506476Z    6:     0x55cfbe7ae831 - std::io::impls::<impl std::io::Write for alloc::boxed::Box<W>>::write_fmt::ha927d7e5f294bce5
2020-09-10T13:03:23.5506711Z                                at src/libstd/io/impls.rs:176
2020-09-10T13:03:23.5507255Z    7:     0x55cfbe7ab780 - std::sys_common::backtrace::_print::hfc0110703f3696fd
2020-09-10T13:03:23.5507477Z                                at src/libstd/sys_common/backtrace.rs:62
2020-09-10T13:03:23.5508019Z    8:     0x55cfbe7ab780 - std::sys_common::backtrace::print::h3f77c6990ddfaa22
2020-09-10T13:03:23.5508237Z                                at src/libstd/sys_common/backtrace.rs:49
2020-09-10T13:03:23.5508790Z    9:     0x55cfbe7ab780 - std::panicking::default_hook::{{closure}}::heae49580a8d62d75
2020-09-10T13:03:23.5509010Z                                at src/libstd/panicking.rs:198
2020-09-10T13:03:23.5509710Z   10:     0x55cfbe7aaead - std::panicking::default_hook::hecc34e3f729e213c
2020-09-10T13:03:23.5510047Z                                at src/libstd/panicking.rs:214
2020-09-10T13:03:23.5510690Z error: test failed, to rerun pass '-p deno --test integration_tests'
2020-09-10T13:03:23.5511341Z   11:     0x55cfbe7aaead - std::panicking::rust_panic_with_hook::he82f5d0644692441
2020-09-10T13:03:23.5511515Z                                at src/libstd/panicking.rs:526
2020-09-10T13:03:23.5511786Z   12:     0x55cfbe7aab08 - rust_begin_unwind
2020-09-10T13:03:23.5511951Z                                at src/libstd/panicking.rs:437
2020-09-10T13:03:23.5512719Z   13:     0x55cfbe742350 - core::panicking::panic_fmt::h09c929f06bb87c98
2020-09-10T13:03:23.5513142Z                                at src/libcore/panicking.rs:85
2020-09-10T13:03:23.5513878Z   14:     0x55cfbe744d42 - core::option::expect_none_failed::h188f17af6c9f404b
2020-09-10T13:03:23.5514074Z                                at src/libcore/option.rs:1269
2020-09-10T13:03:23.5514819Z   15:     0x55cfbe71e9a3 - core::result::Result<T,E>::unwrap::h39fbb43e56892ccf
2020-09-10T13:03:23.5515343Z   16:     0x55cfbe71bf80 - core::ops::function::FnOnce::call_once::hf8af0ee11cb1bb69
2020-09-10T13:03:23.5526357Z   17:     0x55cfbe7eb759 - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h6633cb15d0d76942
2020-09-10T13:03:23.5526727Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
2020-09-10T13:03:23.5527429Z   18:     0x55cfbe7eb759 - <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::h1e20120def172c5c
2020-09-10T13:03:23.5527689Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:318
2020-09-10T13:03:23.5528245Z   19:     0x55cfbe7eb759 - std::panicking::try::do_call::hcc2ec3bbb75e9316
2020-09-10T13:03:23.5528493Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:348
2020-09-10T13:03:23.5529191Z   20:     0x55cfbe7eb759 - std::panicking::try::h94eaebaaa7dd6f41
2020-09-10T13:03:23.5529462Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:325
2020-09-10T13:03:23.5530055Z   21:     0x55cfbe7eb759 - std::panic::catch_unwind::h151c07c08497cf8b
2020-09-10T13:03:23.5530618Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:394
2020-09-10T13:03:23.5531403Z   22:     0x55cfbe7eb759 - test::run_test_in_process::hd082de93b1922c89
2020-09-10T13:03:23.5531574Z                                at src/libtest/lib.rs:541
2020-09-10T13:03:23.5532019Z   23:     0x55cfbe7eb759 - test::run_test::run_test_inner::{{closure}}::h22369c9424e5ab3a
2020-09-10T13:03:23.5532194Z                                at src/libtest/lib.rs:450
2020-09-10T13:03:23.5532650Z   24:     0x55cfbe7ed7f6 - std::sys_common::backtrace::__rust_begin_short_backtrace::h0660a89f67243e05
2020-09-10T13:03:23.5532866Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/sys_common/backtrace.rs:130
2020-09-10T13:03:23.5533355Z   25:     0x55cfbe7ed6dc - std::thread::Builder::spawn_unchecked::{{closure}}::{{closure}}::h8bb2049509aa1add
2020-09-10T13:03:23.5533569Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/thread/mod.rs:475
2020-09-10T13:03:23.5534074Z   26:     0x55cfbe7ed6dc - <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::hb49f3484cb9c3dd3
2020-09-10T13:03:23.5534588Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:318
2020-09-10T13:03:23.5535171Z   27:     0x55cfbe7ed6dc - std::panicking::try::do_call::ha910a12d1577339b
2020-09-10T13:03:23.5535500Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:348
2020-09-10T13:03:23.5536001Z   28:     0x55cfbe7ed6dc - std::panicking::try::hd8b3d620360e55fa
2020-09-10T13:03:23.5536202Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:325
2020-09-10T13:03:23.5536774Z   29:     0x55cfbe7ed6dc - std::panic::catch_unwind::h475454730ea43154
2020-09-10T13:03:23.5536966Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:394
2020-09-10T13:03:23.5537418Z   30:     0x55cfbe7ed6dc - std::thread::Builder::spawn_unchecked::{{closure}}::h2407d9379d805151
2020-09-10T13:03:23.5537619Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/thread/mod.rs:474
2020-09-10T13:03:23.5538611Z   31:     0x55cfbe7ed6dc - core::ops::function::FnOnce::call_once{{vtable.shim}}::haef9f772dfab225e
2020-09-10T13:03:23.5538897Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libcore/ops/function.rs:233
2020-09-10T13:03:23.5539572Z   32:     0x55cfbe7c4baa - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::hd2b3bc04af94a84f
2020-09-10T13:03:23.5539845Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
2020-09-10T13:03:23.5540461Z   33:     0x55cfbe7c4baa - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h1044417e186e567a
2020-09-10T13:03:23.5540716Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
2020-09-10T13:03:23.5541291Z   34:     0x55cfbe7c4baa - std::sys::unix::thread::Thread::new::thread_start::h276e6ca033938925
2020-09-10T13:03:23.5541518Z                                at src/libstd/sys/unix/thread.rs:87
2020-09-10T13:03:23.5542183Z   35:     0x7fa189fd16db - start_thread
2020-09-10T13:03:23.5542440Z   36:     0x7fa189ae2a3f - __clone
2020-09-10T13:03:23.5542691Z   37:                0x0 - <unknown>
2020-09-10T13:03:23.5542763Z 
2020-09-10T13:03:23.5542839Z 
2020-09-10T13:03:23.5542955Z failures:
2020-09-10T13:03:23.5543083Z     upgrade_in_tmpdir
2020-09-10T13:03:23.5543147Z 
2020-09-10T13:03:23.5543401Z test result: FAILED. 265 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out
2020-09-10T13:03:23.5543514Z
@bartlomieju
Copy link
Member

Another related failure:

2020-09-12T09:20:57.7906987Z 
2020-09-12T09:20:57.7907900Z ---- upgrade_with_space_in_path stdout ----
2020-09-12T09:20:57.7908457Z target_dir /home/runner/work/deno/deno/target/release
2020-09-12T09:20:57.7917448Z ##[error]thread 'upgrade_with_space_in_path' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 26, kind: Other, message: "Text file busy" }', cli/tests/integration_tests.rs:440:6
2020-09-12T09:20:57.7921257Z stack backtrace:
2020-09-12T09:20:57.7922542Z    0:     0x556b4c276042 - backtrace::backtrace::libunwind::trace::h14d338b30b3ea0a7
2020-09-12T09:20:57.7924031Z                                at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
2020-09-12T09:20:57.7925477Z    1:     0x556b4c276042 - backtrace::backtrace::trace_unsynchronized::h73ea91d74a3fd67f
2020-09-12T09:20:57.7926911Z                                at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
2020-09-12T09:20:57.7928202Z    2:     0x556b4c276042 - std::sys_common::backtrace::_print_fmt::hd42948c952866e12
2020-09-12T09:20:57.7928862Z                                at src/libstd/sys_common/backtrace.rs:78
2020-09-12T09:20:57.7930084Z    3:     0x556b4c276042 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::ha8f928866ff7571e
2020-09-12T09:20:57.7930911Z                                at src/libstd/sys_common/backtrace.rs:59
2020-09-12T09:20:57.7931818Z    4:     0x556b4c20d64c - core::fmt::write::he0c1e5f7426d2718
2020-09-12T09:20:57.7932346Z                                at src/libcore/fmt/mod.rs:1076
2020-09-12T09:20:57.7933188Z    5:     0x556b4c2ba314 - std::io::Write::write_fmt::h1152922039931516
2020-09-12T09:20:57.7933933Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/io/mod.rs:1537
2020-09-12T09:20:57.7935131Z error: test failed, to rerun pass '-p deno --test integration_tests'
2020-09-12T09:20:57.7936330Z    6:     0x556b4c278221 - std::io::impls::<impl std::io::Write for alloc::boxed::Box<W>>::write_fmt::ha927d7e5f294bce5
2020-09-12T09:20:57.7936994Z                                at src/libstd/io/impls.rs:176
2020-09-12T09:20:57.7937909Z    7:     0x556b4c275170 - std::sys_common::backtrace::_print::hfc0110703f3696fd
2020-09-12T09:20:57.7938541Z                                at src/libstd/sys_common/backtrace.rs:62
2020-09-12T09:20:57.7939573Z    8:     0x556b4c275170 - std::sys_common::backtrace::print::h3f77c6990ddfaa22
2020-09-12T09:20:57.7940234Z                                at src/libstd/sys_common/backtrace.rs:49
2020-09-12T09:20:57.7941255Z    9:     0x556b4c275170 - std::panicking::default_hook::{{closure}}::heae49580a8d62d75
2020-09-12T09:20:57.7941896Z                                at src/libstd/panicking.rs:198
2020-09-12T09:20:57.7942846Z   10:     0x556b4c27489d - std::panicking::default_hook::hecc34e3f729e213c
2020-09-12T09:20:57.7943460Z                                at src/libstd/panicking.rs:214
2020-09-12T09:20:57.7944408Z   11:     0x556b4c27489d - std::panicking::rust_panic_with_hook::he82f5d0644692441
2020-09-12T09:20:57.7945012Z                                at src/libstd/panicking.rs:526
2020-09-12T09:20:57.7945656Z   12:     0x556b4c2744f8 - rust_begin_unwind
2020-09-12T09:20:57.7946147Z                                at src/libstd/panicking.rs:437
2020-09-12T09:20:57.7947063Z   13:     0x556b4c20bd40 - core::panicking::panic_fmt::h09c929f06bb87c98
2020-09-12T09:20:57.7947649Z                                at src/libcore/panicking.rs:85
2020-09-12T09:20:57.7948597Z   14:     0x556b4c20e732 - core::option::expect_none_failed::h188f17af6c9f404b
2020-09-12T09:20:57.7949182Z                                at src/libcore/option.rs:1269
2020-09-12T09:20:57.7950108Z   15:     0x556b4c1e82c1 - core::result::Result<T,E>::unwrap::h39fbb43e56892ccf
2020-09-12T09:20:57.7951191Z   16:     0x556b4c1d607b - core::ops::function::FnOnce::call_once::h3eccd76cdc4e27c2
2020-09-12T09:20:57.7952374Z   17:     0x556b4c2b5149 - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h6633cb15d0d76942
2020-09-12T09:20:57.7953405Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
2020-09-12T09:20:57.7954923Z   18:     0x556b4c2b5149 - <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::h1e20120def172c5c
2020-09-12T09:20:57.7955896Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:318
2020-09-12T09:20:57.7957044Z   19:     0x556b4c2b5149 - std::panicking::try::do_call::hcc2ec3bbb75e9316
2020-09-12T09:20:57.7957975Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:348
2020-09-12T09:20:57.7959151Z   20:     0x556b4c2b5149 - std::panicking::try::h94eaebaaa7dd6f41
2020-09-12T09:20:57.7959989Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:325
2020-09-12T09:20:57.7961102Z   21:     0x556b4c2b5149 - std::panic::catch_unwind::h151c07c08497cf8b
2020-09-12T09:20:57.7961885Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:394
2020-09-12T09:20:57.7962985Z   22:     0x556b4c2b5149 - test::run_test_in_process::hd082de93b1922c89
2020-09-12T09:20:57.7963522Z                                at src/libtest/lib.rs:541
2020-09-12T09:20:57.7964456Z   23:     0x556b4c2b5149 - test::run_test::run_test_inner::{{closure}}::h22369c9424e5ab3a
2020-09-12T09:20:57.7965020Z                                at src/libtest/lib.rs:450
2020-09-12T09:20:57.7966029Z   24:     0x556b4c2b71e6 - std::sys_common::backtrace::__rust_begin_short_backtrace::h0660a89f67243e05
2020-09-12T09:20:57.7968002Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/sys_common/backtrace.rs:130
2020-09-12T09:20:57.7969383Z   25:     0x556b4c2b70cc - std::thread::Builder::spawn_unchecked::{{closure}}::{{closure}}::h8bb2049509aa1add
2020-09-12T09:20:57.7970313Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/thread/mod.rs:475
2020-09-12T09:20:57.7971723Z   26:     0x556b4c2b70cc - <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::hb49f3484cb9c3dd3
2020-09-12T09:20:57.7972709Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:318
2020-09-12T09:20:57.7973824Z   27:     0x556b4c2b70cc - std::panicking::try::do_call::ha910a12d1577339b
2020-09-12T09:20:57.7974655Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:348
2020-09-12T09:20:57.7975776Z   28:     0x556b4c2b70cc - std::panicking::try::hd8b3d620360e55fa
2020-09-12T09:20:57.7976591Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:325
2020-09-12T09:20:57.7977692Z   29:     0x556b4c2b70cc - std::panic::catch_unwind::h475454730ea43154
2020-09-12T09:20:57.7978466Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:394
2020-09-12T09:20:57.7979673Z   30:     0x556b4c2b70cc - std::thread::Builder::spawn_unchecked::{{closure}}::h2407d9379d805151
2020-09-12T09:20:57.7980547Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/thread/mod.rs:474
2020-09-12T09:20:57.7981818Z   31:     0x556b4c2b70cc - core::ops::function::FnOnce::call_once{{vtable.shim}}::haef9f772dfab225e
2020-09-12T09:20:57.7982772Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libcore/ops/function.rs:233
2020-09-12T09:20:57.7984093Z   32:     0x556b4c28e59a - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::hd2b3bc04af94a84f
2020-09-12T09:20:57.7985018Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
2020-09-12T09:20:57.7986269Z   33:     0x556b4c28e59a - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h1044417e186e567a
2020-09-12T09:20:57.7987247Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
2020-09-12T09:20:57.7988458Z   34:     0x556b4c28e59a - std::sys::unix::thread::Thread::new::thread_start::h276e6ca033938925
2020-09-12T09:20:57.7989084Z                                at src/libstd/sys/unix/thread.rs:87
2020-09-12T09:20:57.7989697Z   35:     0x7f00c00c46db - start_thread
2020-09-12T09:20:57.7990266Z   36:     0x7f00bfbd5a3f - __clone
2020-09-12T09:20:57.7990804Z   37:                0x0 - <unknown>
2020-09-12T09:20:57.7991035Z 
2020-09-12T09:20:57.7991287Z 
2020-09-12T09:20:57.7991566Z failures:
2020-09-12T09:20:57.7991929Z     upgrade_with_space_in_path

@bartlomieju
Copy link
Member

And yet another:

2020-09-12T09:47:22.9295092Z ---- upgrade_in_tmpdir stdout ----
2020-09-12T09:47:22.9296536Z target_dir /home/runner/work/deno/deno/target/release
2020-09-12T09:47:22.9309660Z ##[error]thread 'upgrade_in_tmpdir' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 26, kind: Other, message: "Text file busy" }', cli/tests/integration_tests.rs:417:6
2020-09-12T09:47:22.9316497Z stack backtrace:
2020-09-12T09:47:22.9318941Z    0:     0x559eaed12042 - backtrace::backtrace::libunwind::trace::h14d338b30b3ea0a7
2020-09-12T09:47:22.9321380Z                                at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
2020-09-12T09:47:22.9324167Z    1:     0x559eaed12042 - backtrace::backtrace::trace_unsynchronized::h73ea91d74a3fd67f
2020-09-12T09:47:22.9327141Z                                at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
2020-09-12T09:47:22.9328656Z    2:     0x559eaed12042 - std::sys_common::backtrace::_print_fmt::hd42948c952866e12
2020-09-12T09:47:22.9329325Z                                at src/libstd/sys_common/backtrace.rs:78
2020-09-12T09:47:22.9330907Z    3:     0x559eaed12042 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::ha8f928866ff7571e
2020-09-12T09:47:22.9331750Z                                at src/libstd/sys_common/backtrace.rs:59
2020-09-12T09:47:22.9332729Z    4:     0x559eaeca964c - core::fmt::write::he0c1e5f7426d2718
2020-09-12T09:47:22.9333291Z                                at src/libcore/fmt/mod.rs:1076
2020-09-12T09:47:22.9334897Z    5:     0x559eaed56314 - std::io::Write::write_fmt::h1152922039931516
2020-09-12T09:47:22.9335676Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/io/mod.rs:1537
2020-09-12T09:47:22.9337002Z    6:     0x559eaed14221 - std::io::impls::<impl std::io::Write for alloc::boxed::Box<W>>::write_fmt::ha927d7e5f294bce5
2020-09-12T09:47:22.9338276Z error: test failed, to rerun pass '-p deno --test integration_tests'
2020-09-12T09:47:22.9338877Z                                at src/libstd/io/impls.rs:176
2020-09-12T09:47:22.9339836Z    7:     0x559eaed11170 - std::sys_common::backtrace::_print::hfc0110703f3696fd
2020-09-12T09:47:22.9340584Z                                at src/libstd/sys_common/backtrace.rs:62
2020-09-12T09:47:22.9341521Z    8:     0x559eaed11170 - std::sys_common::backtrace::print::h3f77c6990ddfaa22
2020-09-12T09:47:22.9342152Z                                at src/libstd/sys_common/backtrace.rs:49
2020-09-12T09:47:22.9343352Z    9:     0x559eaed11170 - std::panicking::default_hook::{{closure}}::heae49580a8d62d75
2020-09-12T09:47:22.9344010Z                                at src/libstd/panicking.rs:198
2020-09-12T09:47:22.9344987Z   10:     0x559eaed1089d - std::panicking::default_hook::hecc34e3f729e213c
2020-09-12T09:47:22.9345619Z                                at src/libstd/panicking.rs:214
2020-09-12T09:47:22.9346596Z   11:     0x559eaed1089d - std::panicking::rust_panic_with_hook::he82f5d0644692441
2020-09-12T09:47:22.9347221Z                                at src/libstd/panicking.rs:526
2020-09-12T09:47:22.9347902Z   12:     0x559eaed104f8 - rust_begin_unwind
2020-09-12T09:47:22.9348429Z                                at src/libstd/panicking.rs:437
2020-09-12T09:47:22.9349809Z   13:     0x559eaeca7d40 - core::panicking::panic_fmt::h09c929f06bb87c98
2020-09-12T09:47:22.9350441Z                                at src/libcore/panicking.rs:85
2020-09-12T09:47:22.9351433Z   14:     0x559eaecaa732 - core::option::expect_none_failed::h188f17af6c9f404b
2020-09-12T09:47:22.9352046Z                                at src/libcore/option.rs:1269
2020-09-12T09:47:22.9352997Z   15:     0x559eaec842c1 - core::result::Result<T,E>::unwrap::h39fbb43e56892ccf
2020-09-12T09:47:22.9354104Z   16:     0x559eaec8188c - core::ops::function::FnOnce::call_once::hf8af0ee11cb1bb69
2020-09-12T09:47:22.9355330Z   17:     0x559eaed51149 - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h6633cb15d0d76942
2020-09-12T09:47:22.9356272Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
2020-09-12T09:47:22.9357693Z   18:     0x559eaed51149 - <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::h1e20120def172c5c
2020-09-12T09:47:22.9358694Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:318
2020-09-12T09:47:22.9360192Z   19:     0x559eaed51149 - std::panicking::try::do_call::hcc2ec3bbb75e9316
2020-09-12T09:47:22.9361091Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:348
2020-09-12T09:47:22.9362278Z   20:     0x559eaed51149 - std::panicking::try::h94eaebaaa7dd6f41
2020-09-12T09:47:22.9363409Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:325
2020-09-12T09:47:22.9364663Z   21:     0x559eaed51149 - std::panic::catch_unwind::h151c07c08497cf8b
2020-09-12T09:47:22.9365461Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:394
2020-09-12T09:47:22.9367128Z   22:     0x559eaed51149 - test::run_test_in_process::hd082de93b1922c89
2020-09-12T09:47:22.9367690Z                                at src/libtest/lib.rs:541
2020-09-12T09:47:22.9368647Z   23:     0x559eaed51149 - test::run_test::run_test_inner::{{closure}}::h22369c9424e5ab3a
2020-09-12T09:47:22.9369238Z                                at src/libtest/lib.rs:450
2020-09-12T09:47:22.9370285Z   24:     0x559eaed531e6 - std::sys_common::backtrace::__rust_begin_short_backtrace::h0660a89f67243e05
2020-09-12T09:47:22.9371266Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/sys_common/backtrace.rs:130
2020-09-12T09:47:22.9372641Z   25:     0x559eaed530cc - std::thread::Builder::spawn_unchecked::{{closure}}::{{closure}}::h8bb2049509aa1add
2020-09-12T09:47:22.9373592Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/thread/mod.rs:475
2020-09-12T09:47:22.9375016Z   26:     0x559eaed530cc - <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::hb49f3484cb9c3dd3
2020-09-12T09:47:22.9376024Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:318
2020-09-12T09:47:22.9377199Z   27:     0x559eaed530cc - std::panicking::try::do_call::ha910a12d1577339b
2020-09-12T09:47:22.9378155Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:348
2020-09-12T09:47:22.9379232Z   28:     0x559eaed530cc - std::panicking::try::hd8b3d620360e55fa
2020-09-12T09:47:22.9380012Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:325
2020-09-12T09:47:22.9381317Z   29:     0x559eaed530cc - std::panic::catch_unwind::h475454730ea43154
2020-09-12T09:47:22.9382106Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:394
2020-09-12T09:47:22.9383360Z   30:     0x559eaed530cc - std::thread::Builder::spawn_unchecked::{{closure}}::h2407d9379d805151
2020-09-12T09:47:22.9384257Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/thread/mod.rs:474
2020-09-12T09:47:22.9385878Z   31:     0x559eaed530cc - core::ops::function::FnOnce::call_once{{vtable.shim}}::haef9f772dfab225e
2020-09-12T09:47:22.9386880Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libcore/ops/function.rs:233
2020-09-12T09:47:22.9388274Z   32:     0x559eaed2a59a - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::hd2b3bc04af94a84f
2020-09-12T09:47:22.9389230Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
2020-09-12T09:47:22.9390545Z   33:     0x559eaed2a59a - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h1044417e186e567a
2020-09-12T09:47:22.9391535Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
2020-09-12T09:47:22.9393548Z   34:     0x559eaed2a59a - std::sys::unix::thread::Thread::new::thread_start::h276e6ca033938925
2020-09-12T09:47:22.9394161Z                                at src/libstd/sys/unix/thread.rs:87
2020-09-12T09:47:22.9394926Z   35:     0x7f7abb4316db - start_thread
2020-09-12T09:47:22.9395476Z   36:     0x7f7abaf42a3f - __clone
2020-09-12T09:47:22.9396109Z   37:                0x0 - <unknown>
2020-09-12T09:47:22.9396506Z 
2020-09-12T09:47:22.9396679Z 
2020-09-12T09:47:22.9396941Z failures:
2020-09-12T09:47:22.9397264Z     upgrade_in_tmpdir

@lucacasonato
Copy link
Member

upgrade_with_version_in_tmpdir is also flaky https://github.com/denoland/deno/runs/1105716860

2020-09-12T12:16:40.8480782Z ---- upgrade_with_version_in_tmpdir stdout ----
2020-09-12T12:16:40.8481319Z target_dir /home/runner/work/deno/deno/target/release
2020-09-12T12:16:40.8492476Z ##[error]thread 'upgrade_with_version_in_tmpdir' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 26, kind: Other, message: "Text file busy" }', cli/tests/integration_tests.rs:460:6
2020-09-12T12:16:40.8497341Z stack backtrace:
2020-09-12T12:16:40.8498537Z    0:     0x5640b25fb042 - backtrace::backtrace::libunwind::trace::h14d338b30b3ea0a7
2020-09-12T12:16:40.8500798Z                                at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
2020-09-12T12:16:40.8502209Z    1:     0x5640b25fb042 - backtrace::backtrace::trace_unsynchronized::h73ea91d74a3fd67f
2020-09-12T12:16:40.8503455Z                                at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
2020-09-12T12:16:40.8505164Z error: test failed, to rerun pass '-p deno --test integration_tests'
2020-09-12T12:16:40.8506238Z    2:     0x5640b25fb042 - std::sys_common::backtrace::_print_fmt::hd42948c952866e12
2020-09-12T12:16:40.8506918Z                                at src/libstd/sys_common/backtrace.rs:78
2020-09-12T12:16:40.8508080Z    3:     0x5640b25fb042 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::ha8f928866ff7571e
2020-09-12T12:16:40.8509636Z                                at src/libstd/sys_common/backtrace.rs:59
2020-09-12T12:16:40.8510598Z    4:     0x5640b259264c - core::fmt::write::he0c1e5f7426d2718
2020-09-12T12:16:40.8511045Z                                at src/libcore/fmt/mod.rs:1076
2020-09-12T12:16:40.8511940Z    5:     0x5640b263f314 - std::io::Write::write_fmt::h1152922039931516
2020-09-12T12:16:40.8512689Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/io/mod.rs:1537
2020-09-12T12:16:40.8514332Z    6:     0x5640b25fd221 - std::io::impls::<impl std::io::Write for alloc::boxed::Box<W>>::write_fmt::ha927d7e5f294bce5
2020-09-12T12:16:40.8514913Z                                at src/libstd/io/impls.rs:176
2020-09-12T12:16:40.8515898Z    7:     0x5640b25fa170 - std::sys_common::backtrace::_print::hfc0110703f3696fd
2020-09-12T12:16:40.8516427Z                                at src/libstd/sys_common/backtrace.rs:62
2020-09-12T12:16:40.8517901Z    8:     0x5640b25fa170 - std::sys_common::backtrace::print::h3f77c6990ddfaa22
2020-09-12T12:16:40.8518909Z                                at src/libstd/sys_common/backtrace.rs:49
2020-09-12T12:16:40.8520096Z    9:     0x5640b25fa170 - std::panicking::default_hook::{{closure}}::heae49580a8d62d75
2020-09-12T12:16:40.8520848Z                                at src/libstd/panicking.rs:198
2020-09-12T12:16:40.8522515Z   10:     0x5640b25f989d - std::panicking::default_hook::hecc34e3f729e213c
2020-09-12T12:16:40.8523741Z                                at src/libstd/panicking.rs:214
2020-09-12T12:16:40.8525223Z   11:     0x5640b25f989d - std::panicking::rust_panic_with_hook::he82f5d0644692441
2020-09-12T12:16:40.8525888Z                                at src/libstd/panicking.rs:526
2020-09-12T12:16:40.8526422Z   12:     0x5640b25f94f8 - rust_begin_unwind
2020-09-12T12:16:40.8526978Z                                at src/libstd/panicking.rs:437
2020-09-12T12:16:40.8528135Z   13:     0x5640b2590d40 - core::panicking::panic_fmt::h09c929f06bb87c98
2020-09-12T12:16:40.8528586Z                                at src/libcore/panicking.rs:85
2020-09-12T12:16:40.8529334Z   14:     0x5640b2593732 - core::option::expect_none_failed::h188f17af6c9f404b
2020-09-12T12:16:40.8529769Z                                at src/libcore/option.rs:1269
2020-09-12T12:16:40.8530499Z   15:     0x5640b256d2c1 - core::result::Result<T,E>::unwrap::h39fbb43e56892ccf
2020-09-12T12:16:40.8531832Z   16:     0x5640b255e954 - core::ops::function::FnOnce::call_once::h639e28cab24443bd
2020-09-12T12:16:40.8532999Z   17:     0x5640b263a149 - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h6633cb15d0d76942
2020-09-12T12:16:40.8533859Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
2020-09-12T12:16:40.8535477Z   18:     0x5640b263a149 - <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::h1e20120def172c5c
2020-09-12T12:16:40.8536330Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:318
2020-09-12T12:16:40.8537298Z   19:     0x5640b263a149 - std::panicking::try::do_call::hcc2ec3bbb75e9316
2020-09-12T12:16:40.8537966Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:348
2020-09-12T12:16:40.8538885Z   20:     0x5640b263a149 - std::panicking::try::h94eaebaaa7dd6f41
2020-09-12T12:16:40.8539535Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:325
2020-09-12T12:16:40.8540443Z   21:     0x5640b263a149 - std::panic::catch_unwind::h151c07c08497cf8b
2020-09-12T12:16:40.8541045Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:394
2020-09-12T12:16:40.8541935Z   22:     0x5640b263a149 - test::run_test_in_process::hd082de93b1922c89
2020-09-12T12:16:40.8542350Z                                at src/libtest/lib.rs:541
2020-09-12T12:16:40.8543098Z   23:     0x5640b263a149 - test::run_test::run_test_inner::{{closure}}::h22369c9424e5ab3a
2020-09-12T12:16:40.8543536Z                                at src/libtest/lib.rs:450
2020-09-12T12:16:40.8544344Z   24:     0x5640b263c1e6 - std::sys_common::backtrace::__rust_begin_short_backtrace::h0660a89f67243e05
2020-09-12T12:16:40.8545082Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/sys_common/backtrace.rs:130
2020-09-12T12:16:40.8546146Z   25:     0x5640b263c0cc - std::thread::Builder::spawn_unchecked::{{closure}}::{{closure}}::h8bb2049509aa1add
2020-09-12T12:16:40.8547034Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/thread/mod.rs:475
2020-09-12T12:16:40.8548126Z   26:     0x5640b263c0cc - <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::hb49f3484cb9c3dd3
2020-09-12T12:16:40.8548861Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:318
2020-09-12T12:16:40.8549737Z   27:     0x5640b263c0cc - std::panicking::try::do_call::ha910a12d1577339b
2020-09-12T12:16:40.8550357Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:348
2020-09-12T12:16:40.8551241Z   28:     0x5640b263c0cc - std::panicking::try::hd8b3d620360e55fa
2020-09-12T12:16:40.8551848Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:325
2020-09-12T12:16:40.8552706Z   29:     0x5640b263c0cc - std::panic::catch_unwind::h475454730ea43154
2020-09-12T12:16:40.8553573Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:394
2020-09-12T12:16:40.8554569Z   30:     0x5640b263c0cc - std::thread::Builder::spawn_unchecked::{{closure}}::h2407d9379d805151
2020-09-12T12:16:40.8555241Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/thread/mod.rs:474
2020-09-12T12:16:40.8556266Z   31:     0x5640b263c0cc - core::ops::function::FnOnce::call_once{{vtable.shim}}::haef9f772dfab225e
2020-09-12T12:16:40.8557162Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libcore/ops/function.rs:233
2020-09-12T12:16:40.8558184Z   32:     0x5640b261359a - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::hd2b3bc04af94a84f
2020-09-12T12:16:40.8558873Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
2020-09-12T12:16:40.8559850Z   33:     0x5640b261359a - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h1044417e186e567a
2020-09-12T12:16:40.8560512Z                                at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
2020-09-12T12:16:40.8561448Z   34:     0x5640b261359a - std::sys::unix::thread::Thread::new::thread_start::h276e6ca033938925
2020-09-12T12:16:40.8561919Z                                at src/libstd/sys/unix/thread.rs:87
2020-09-12T12:16:40.8562494Z   35:     0x7fd17957b6db - start_thread
2020-09-12T12:16:40.8562977Z   36:     0x7fd17908ca3f - __clone
2020-09-12T12:16:40.8563566Z   37:                0x0 - <unknown>
2020-09-12T12:16:40.8563759Z 
2020-09-12T12:16:40.8563891Z 
2020-09-12T12:16:40.8564161Z failures:
2020-09-12T12:16:40.8564464Z     upgrade_with_version_in_tmpdir

@lucacasonato
Copy link
Member

lucacasonato commented Sep 12, 2020 •
edited
Loading

temporarily disabled all upgrade tests in #7435 and #7437

@lucacasonato lucacasonato changed the title upgrade_in_tmpdir flaky after faster runner upgrade reenable upgrade tests Sep 17, 2020
@stale
Copy link

stale bot commented Jan 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 6, 2021
@stale stale bot closed this as completed Jan 13, 2021
@lucacasonato lucacasonato added the tests related to tests label Jan 14, 2021
@lucacasonato lucacasonato reopened this Jan 14, 2021
@stale stale bot removed the stale label Jan 14, 2021
@GJZwiers GJZwiers mentioned this issue Mar 15, 2023
Closed
@dsherret dsherret mentioned this issue Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(tests): enable upgrade_tests again
3 participants
@ry @lucacasonato @bartlomieju