Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WebSocket): no panic on failed connect + handle promise rejection via error event #7437

Merged
merged 6 commits into from
Sep 13, 2020
Merged

fix(WebSocket): no panic on failed connect + handle promise rejection via error event #7437

merged 6 commits into from
Sep 13, 2020

Conversation

lucacasonato
Copy link
Member

This PR fixes two somewhat unrelated issues:

  1. Panic when connection to WS fails
  2. WebSocket connection errors are 'returned' via unhandled rejection rather than via error event

@lucacasonato lucacasonato changed the title fix: no panic on failed connect + proper onerror fix(WebSocket): no panic on failed connect + handle promise rejection via error event Sep 12, 2020
ry
ry approved these changes Sep 13, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit daa780e into denoland:master Sep 13, 2020
@lucacasonato lucacasonato deleted the fix_panic_on_ws_connect branch September 13, 2020 09:52
@lucacasonato lucacasonato mentioned this pull request Sep 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucacasonato @ry