chore(tests): enable upgrade_tests again

[GJZwiers]

Closes #7412

These tests would sometimes throw an ExecutableFileBusy error, most likely due to parallel std::fs::copy calls of the same file. This is an attempt to fix the issue by switching to std::fs::hard_link.

[aapoalas]

LGTM. Let's hope this indeed does fix the flakiness.

[GJZwiers]

Looks like they are still flaky after all

[aapoalas]

Yup :(

[GJZwiers]

@aapoalas @bartlomieju The upgrade_with_out_in_tmpdir test seems to have broken in 0742ea1 (which was not caught because it is ignored on main) rather than it being flaky, because locally it fails consistently for me from that commit onwards but not before that.

[bartlomieju]

@GJZwiers good catch; should we revert that change or can it be fixed in-line in this PR?

[GJZwiers]

@bartlomieju I think maybe it should be reverted, there was a regression in 0742ea1 because deno upgrade --output fails on the canary version same as the test:

cd /tmp
mkdir foo
deno upgrade --version 1.11.5 --output foo/deno
error: No such file or directory (os error 2)

But on 1.32.1 it works:

deno upgrade --version 1.11.5 --output foo/deno
Downloading https://github.com/denoland/deno/releases/download/v1.11.5/deno-x86_64-unknown-linux-gnu.zip
Deno is upgrading to version 1.11.5
Archive:  /tmp/.tmp2QmbJs/deno.zip
  inflating: deno                    
Upgraded successfully
Release notes: https://github.com/denoland/deno/releases/tag/v1.11.5
Blog post: https://deno.com/blog/v1.11

[GJZwiers]

@bartlomieju I am getting test failures after pulling the latest main branch but only on Windows. It does not happen locally, was anything changed to the CI recently?

thread 'integration::upgrade::upgrade_with_version_in_tmpdir' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 17, kind: CrossesDevices, message: "The system cannot move the file to a different disk drive." }', cli\tests\integration\upgrade_tests.rs:51:56