New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use incremental build in ci #10053
Conversation
.github/workflows/ci.yml
Outdated
@@ -58,7 +58,7 @@ jobs: | |||
# Use depth > 1, because sometimes we need to rebuild main and if | |||
# other commits have landed it will become impossible to rebuild if | |||
# the checkout is too shallow. | |||
fetch-depth: 5 | |||
fetch-depth: '0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this comment still stands - maybe we shouldn't go with depth 5 but 1 or 2 is highly desired
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0
means disabling shallow clone i.e. fetching all history. (this is needed for updating the modified timestamps based on git history) ref: https://github.com/actions/checkout#checkout-v2
So I'll update the comment.
1d9d83a
to
e15cc7c
Compare
I think you should also do this for submodules. Currently only files from the "root" git repo get treated. |
We can think of ways to make this even better, but let's land it as-is first and enjoy the 2x reduction in CI build time immediately. |
@bartlomieju You have the final say. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can think of ways to make this even better, but let's land it as-is first and enjoy the 2x reduction in CI build time immediately.
Let's go 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you Yoshiya!
This reverts commit fd65e6d.
This reverts commit fd65e6d.
This reverts commit fd65e6d.
This reverts commit fd65e6d.
This PR enables the incremental build of rust code in CI by the following changes:
CARGO_INCREMENTAL=1
. (release
profile hasincremental = false
setting by default.)matrix.kind
in part of cache key becausetest_release
andtest_debug
can't share the cache../tools/restore_mtime.py
)I tested this setting in my detached fork. windows job passed in 11 minutes https://github.com/kt3k/deno_ci_test/runs/2285441107