test(cli): run unit tests using Deno.test

[caspervonb]

This removes the old unit test runner and migrates all unit tests to run with deno test instead.

[caspervonb]

WebGPU test is leaking because destroy seemingly doesn't seem to close the resources it owns.
After destroy is called, the resource keys are:

[ "0", "1", "2", "973", "982", "984" ]

See run https://github.com/denoland/deno/runs/2437592943

I've disabled the test for now.

[bartlomieju]

WebGPU test is leaking because destroy seemingly doesn't seem to close the resources it owns.
After destroy is called, the resource keys are:

[ "0", "1", "2", "973", "982", "984" ]

See run https://github.com/denoland/deno/runs/2437592943

I've disabled the test for now.

It's a bit disconcerting that it started failing after this change

[bartlomieju]

@caspervonb is there anything preventing us from removing unitTest wrapper completely? I know that it'll be painful and a huge diff, but asking out of curiosity

[bartlomieju]

I'd be great to keep this README file, it's especially useful to look up command to run a single test. Please retain it and update the examples.

[bartlomieju]

Great to see it go

[caspervonb]

@caspervonb is there anything preventing us from removing unitTest wrapper completely? I know that it'll be painful and a huge diff, but asking out of curiosity

Nothing preventing it, we can remove it completely in a follow-up.
Preferably once we've decided if we want an options bag overload or not.

[bartlomieju]

@caspervonb is there anything preventing us from removing unitTest wrapper completely? I know that it'll be painful and a huge diff, but asking out of curiosity

Nothing preventing it, we can remove it completely in a follow-up.
Preferably once we've decided if we want an options bag overload or not.

Is the option bag required for that? IIRC most of the tests are already written using single option bag.

[caspervonb]

Is the option bag required for that? IIRC most of the tests are already written using single option bag.

Not required, just nicer imho.
Most unit tests are in this form:

unitTest("foobla", {
  perms: { read: false, write: true },
}, function() {
  // ...
});

[bartlomieju]

Is the option bag required for that? IIRC most of the tests are already written using single option bag.

Not required, just nicer imho.
Most unit tests are in this form:

unitTest("foobla", {
  perms: { read: false, write: true },
}, function() {
  // ...
});

I see, thanks for the heads up!

[bartlomieju]

LGTM, exciting!